Commit add's a day option to the display options in RaidPal #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Didn't add any screenshot updates for this as it feels more consistent to have them for your account @kfitzgerald :) |
Owner
|
LGTM – I'm inclined to make this the default and eliminate the toggle entirely. I don't see a downside to always displaying the weekday. Thoughts? |
…e (fix missing CustomEventReducer); keep Day display PR unaffected
Contributor
Author
|
Updated the PR to display 'Day' all the time, also fixed a little bit of bleedover from #10 where the Custom event slice didn't get reverted correctly. |
Contributor
Author
|
Closed this PR as the day display is included in #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional “Day” toggle to RaidPal to show weekday abbreviations next to times. This improves quick scanning and reduces ambiguity for cross‑timezone or overnight slots.