Skip to content

Add code quality improvements, manually and with clang-tidy/clang-format#310

Open
red-robby wants to merge 16 commits intomasterfrom
dev-sdk-code-quality
Open

Add code quality improvements, manually and with clang-tidy/clang-format#310
red-robby wants to merge 16 commits intomasterfrom
dev-sdk-code-quality

Conversation

@red-robby
Copy link
Copy Markdown
Contributor

These changes are minimal and include:

  • Marking members functions as const/noexcept if appropriate.
  • Using the standard types from <cstdint> (and prepending all such types with std::).
  • Removing constructors that just initialized member variables. Instead, we initialize them where they are declared.
  • Replacing some constants expressed as macros with equivalent (type safe) constexpr values.

No code logic has been modified.

@red-robby red-robby requested a review from dayeol January 31, 2023 09:52
@red-robby red-robby self-assigned this Jan 31, 2023
@red-robby red-robby changed the title Add basic code quality improvements to SDK/host Add code quality improvements, manually and with clang-tidy/clang-format Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant