chore(developer): update multer dependency for server#7314
Merged
Conversation
Removes Keyman Developer Server's transitive dependency on dicer by updating multer to `1.4.5-lts.1`, which updates its dependency on busboy. See expressjs/multer#1097 (comment) for reasoning behind use of `-lts.1` rather than a full release version. At some point in the future, multer will publish a full release with this fix, at which point we can move back to a full release version.
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
approved these changes
Sep 20, 2022
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
packge-lock.json has merge conflicts, but lgtm after that's resolved :)
mcdurdin
deleted the
chore/developer/server-update-multer-dependency
branch
Collaborator
|
Changes in this pull request will be available for download in Keyman version 16.0.68-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Keyman Developer Server's transitive dependency on dicer by updating multer to
1.4.5-lts.1, which updates its dependency on busboy.See expressjs/multer#1097 (comment) for reasoning behind use of
-lts.1rather than a full release version.At some point in the future, multer will publish a full release with this fix, at which point we can move back to a full release version.
@keymanapp-test-bot skip