fix(core): fix keydown/up handling for LDML keyboards #️⃣#15609
Draft
ermshiperete wants to merge 1 commit intotest/core/minkbdfrom
Draft
fix(core): fix keydown/up handling for LDML keyboards #️⃣#15609ermshiperete wants to merge 1 commit intotest/core/minkbdfrom
ermshiperete wants to merge 1 commit intotest/core/minkbdfrom
Conversation
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
ermshiperete
changed the title
ermshiperete
force-pushed
the
fix/core/15569_ldml
branch
from
be6307c to
f67f988
Compare
For LDML keyboards this change fixes the `emit_key` flag so that it has the same value for the KeyDown and the KeyUp event. This fixes some problems with stuck keys. Previously we would set `emit_key=TRUE` on KeyDown but `emit_key=FALSE` on KeyUp for frame keys. This caused Linux to never see the KeyUp event, resulting in a stuck key. Also add unit tests that verifies that the actions that we get after calling `km_core_process_event` are what we expect. Fixes: #15569 Fixes: #15550
ermshiperete
force-pushed
the
fix/core/15569_ldml
branch
from
f67f988 to
c0b6426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For LDML keyboards this change fixes the
emit_keyflag so that it has the same value for the KeyDown and the KeyUp event. This fixes some problems with stuck keys. Previously we would setemit_key=TRUEon KeyDown butemit_key=FALSEon KeyUp for frame keys. This caused Linux to never see the KeyUp event, resulting in a stuck key.Also add unit tests that verifies that the actions that we get after calling
km_core_process_eventare what we expect.Fixes: #15569
Fixes: #15550