Skip to content

test(core): add LDML baseline test with minimal keyboard #️⃣ #15608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ermshiperete wants to merge 1 commit into
base: refactor/core/loop
Choose a base branch
from
+24 −12
Open

test(core): add LDML baseline test with minimal keyboard #️⃣ #15608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions core/tests/unit/ldml/keyboards/k_000_minimal_keyboard.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--

Keys that don't show up in a row don't generate an output

@@keys: [K_Q][K_W]
@@expected: q

-->
<keyboard3 xmlns="https://schemas.unicode.org/cldr/45/keyboard3" locale="en" conformsTo="45">
<info author="eb" layout="qwerty" name="k_000_minimal_keyboard" />

<keys>
<!-- no keys listed, keys-Latn-implied.xml will be implicitly imported -->
</keys>

<layers formId="us">
<layer id="base">
<row keys="1" />
<row keys="q" />
</layer>
</layers>
</keyboard3>
10 changes: 0 additions & 10 deletions core/tests/unit/ldml/keyboards/k_000_null_keyboard.xml
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions core/tests/unit/ldml/keyboards/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ tests_from_cldr = [

# these have 'embedded' (@@) testdata instead of a separate file
tests_without_testdata = [
# disabling 000 until we have updates to core or to the keyboard so that it passes
# 'k_000_null_keyboard',
'k_000_minimal_keyboard',
'k_002_tinyu32',
'k_003_transform',
'k_004_tinyshift',
Expand Down