Skip to content

Comments

maint(common): Update crowdin.yml to work with Crowdin CLI 4.0+#15407

Merged
darcywong00 merged 4 commits intomasterfrom
maint/common/crowdin-cli-4
Jan 12, 2026
Merged

maint(common): Update crowdin.yml to work with Crowdin CLI 4.0+#15407
darcywong00 merged 4 commits intomasterfrom
maint/common/crowdin-cli-4

Conversation

@darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Jan 8, 2026

Addresses #12116 and fixes #15392

This makes a few changes to the crowdin.yml configuration file to work on Crowdin CLI 4.0+ (which the GitHub action also uses).
I've verified locally with Crowdin CLI v4.12.0.

crowdin.bat download -b master -l km
  • JSON-ify the yml file so it matches the sample formatting in Crowdin CLI documentation
  • Currently have to comment out custom languages: el-polyton, shu-latn-n. These were flagging the Crowdin language mapping errors. I'm currently blocked on troubleshooting these until I can get sil_ltops credentials in the Crowdin project.

Test-bot: skip
Build-bot: skip

@darcywong00 darcywong00 added this to the A19S20 milestone Jan 8, 2026
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@github-project-automation github-project-automation bot moved this to Todo in Keyman Jan 8, 2026
@github-actions github-actions bot added common/ maint Maintenance work -- continuous integration, build scripts, infrastructure labels Jan 8, 2026
@github-actions github-actions bot added common/ and removed common/ labels Jan 8, 2026
@github-actions github-actions bot added common/ and removed common/ labels Jan 8, 2026
crowdin.yml Outdated
# Files configuration
#
files:
files: [{
Copy link
Contributor

@ermshiperete ermshiperete Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be necessary to use json syntax in a yml file.

It would be cleaner to stay with yml syntax, or completely move the syntax for the entire file to json and rename the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the JSON syntax

Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcywong00 darcywong00 merged commit 36d21a6 into master Jan 12, 2026
6 checks passed
@darcywong00 darcywong00 deleted the maint/common/crowdin-cli-4 branch January 12, 2026 01:20
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jan 12, 2026
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.189-alpha

@mcdurdin
Copy link
Member

Can #15395 and #12116 be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common/ maint Maintenance work -- continuous integration, build scripts, infrastructure

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

maint(common): Crowdin GHA still failing

4 participants