Skip to content

refactor(web): refactor local input cost heuristic 🚂 #15405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahorton merged 1 commit into from
Jan 22, 2026
Merged

refactor(web): refactor local input cost heuristic 🚂 #15405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions web/src/engine/predictive-text/worker-thread/src/main/correction/search-quotient-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ export interface SearchQuotientNode {
*/
readonly currentCost: number;

/**
* Provides a heuristic for the base cost at this path's depth if the best
* individual input were taken here, regardless of whether or not that's
* possible.
*
* This cost is based on the negative log-likelihood of the probability and
* includes the cost from the lowest possible parent nodes visited.
*/
readonly lowestPossibleSingleCost: number;

/**
* Returns the set of previously-processed results under this batcher's domain.
*/
Expand Down
17 changes: 8 additions & 9 deletions web/src/engine/predictive-text/worker-thread/src/main/correction/search-quotient-spur.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@ export class SearchQuotientSpur implements SearchQuotientNode {
readonly spaceId: number;

/**
* Marks all results that have already been returned since the last input was received.
* Is cleared after .addInput() calls.
* Marks all results that have already been returned from this instance of SearchPath.
* Should be deleted and cleared if any paths consider this one as a parent.
*/
private returnedValues?: {[resultKey: string]: SearchNode} = {};

/**
* Provides a heuristic for the base cost at each depth if the best
* individual input were taken at that level.
* Provides a heuristic for the base cost at this path's depth if the best
* individual input were taken here, regardless of whether or not that's possible.
*/
private lowestCostAtDepth: number[];
readonly lowestPossibleSingleCost: number;

/**
* Constructs a fresh SearchSpace instance for used in predictive-text correction
Expand All @@ -61,7 +61,7 @@ export class SearchQuotientSpur implements SearchQuotientNode {
const logTierCost = -Math.log(bestProbFromSet);

this.inputs = inputs;
this.lowestCostAtDepth = parentNode.lowestCostAtDepth.concat(logTierCost);
this.lowestPossibleSingleCost = parentNode.lowestPossibleSingleCost + logTierCost;
this.parentPath = parentNode;

this.addEdgesForNodes(parentNode.previousResults.map(v => v.node));
Expand All @@ -71,7 +71,7 @@ export class SearchQuotientSpur implements SearchQuotientNode {

const model = arg1 as LexicalModel;
this.selectionQueue.enqueue(new SearchNode(model.traverseFromRoot(), this.spaceId, t => model.toKey(t)));
this.lowestCostAtDepth = [];
this.lowestPossibleSingleCost = 0;
}

/**
Expand Down Expand Up @@ -202,8 +202,7 @@ export class SearchQuotientSpur implements SearchQuotientNode {
// ... or even just not the then-current layer of the keyboard.
//
// TODO: still consider the lowest-cost individual edges for THIS specific criterion.
const tierMinCost = this.lowestCostAtDepth[currentNode.priorInput.length-1];
if(currentNode.currentCost > tierMinCost + 2.5 * EDIT_DISTANCE_COST_SCALE) {
if(currentNode.currentCost > this.lowestPossibleSingleCost + 2.5 * EDIT_DISTANCE_COST_SCALE) {
return unmatchedResult;
}

Expand Down