Skip to content

Comments

fix(web): corrections deleting keystrokes should have a flat correction cost 🚂#15400

Merged
jahorton merged 3 commits intoepic/autocorrectfrom
fix/web/delete-corrections-flat-cost
Jan 22, 2026
Merged

fix(web): corrections deleting keystrokes should have a flat correction cost 🚂#15400
jahorton merged 3 commits intoepic/autocorrectfrom
fix/web/delete-corrections-flat-cost

Conversation

@jahorton
Copy link
Contributor

@jahorton jahorton commented Jan 6, 2026

That is, corrections that eliminate user keystrokes from consideration should have a flat cost regardless of the keystroke's original transform distribution. Neither deleteLeft nor insert effects should have any impact.

Fixes: #15325

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 6, 2026

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(web): deletions should have flat cost fix(web): deletions should have flat cost 🚂 Jan 6, 2026
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S20 milestone Jan 6, 2026
@jahorton jahorton changed the title fix(web): deletions should have flat cost 🚂 fix(web): corrections deleting keystrokes should have flat cost Jan 6, 2026
@jahorton jahorton changed the title fix(web): corrections deleting keystrokes should have flat cost fix(web): corrections deleting keystrokes should have a flat correction cost Jan 6, 2026
@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(web): corrections deleting keystrokes should have a flat correction cost fix(web): corrections deleting keystrokes should have a flat correction cost 🚂 Jan 6, 2026
@jahorton jahorton force-pushed the fix/web/prevent-insdel-sub-aliasing branch from 578cfdc to bfad3ef Compare January 9, 2026 17:12
That is, corrections that eliminate user keystrokes from consideration should have a flat cost regardless of the keystroke's original transform distribution.  Neither deleteLeft nor insert effects should have any impact.

Fixes: #15325

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the fix/web/delete-corrections-flat-cost branch from a65dcf4 to 2a04d35 Compare January 9, 2026 17:14
@jahorton jahorton marked this pull request as ready for review January 14, 2026 21:28
@keyman-server keyman-server modified the milestones: A19S20, A19S21 Jan 16, 2026
Base automatically changed from fix/web/prevent-insdel-sub-aliasing to epic/autocorrect January 22, 2026 14:07
@jahorton jahorton merged commit d43e06c into epic/autocorrect Jan 22, 2026
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jan 22, 2026
@jahorton jahorton deleted the fix/web/delete-corrections-flat-cost branch January 22, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants