Skip to content

Comments

change(web): rename TokenInputSource as PathInputProperties + restructure it 🚂#15140

Merged
jahorton merged 4 commits intoepic/autocorrectfrom
change/web/rename-inputsource-as-pathinputprops
Jan 28, 2026
Merged

change(web): rename TokenInputSource as PathInputProperties + restructure it 🚂#15140
jahorton merged 4 commits intoepic/autocorrectfrom
change/web/rename-inputsource-as-pathinputprops

Conversation

@jahorton
Copy link
Contributor

@jahorton jahorton commented Nov 11, 2025

With the TokenInputSource type now owned by SearchQuotientNodes, rather than ContextTokens, the nomenclature is now pretty inaccurate. Furthermore, two upcoming PRs will add properties to the type; a little restructuring of its contents now will facilitate their upcoming additions and help avoid unwanted side-effects.

Build-bot: skip build:web
Test-bot: skip

Suggestions for alternative nomenclature for PathInputProperties are welcomed. (Perhaps NodeInputProperties... or better yet, SpurInputProperties?)

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 11, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot changed the title change(web): rename TokenInputSource as PathInputProperties + restructure it change(web): rename TokenInputSource as PathInputProperties + restructure it 🚂 Nov 11, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S16 milestone Nov 11, 2025
@github-actions github-actions bot added the change Minor change in functionality, but not new label Nov 11, 2025
@keyman-server keyman-server modified the milestones: A19S16, A19S17 Nov 22, 2025
@keyman-server keyman-server modified the milestones: A19S17, A19S18 Dec 6, 2025
@keyman-server keyman-server modified the milestones: A19S18, A19S19 Dec 21, 2025
@keyman-server keyman-server modified the milestones: A19S19, A19S20 Jan 3, 2026
@jahorton jahorton force-pushed the refactor/web/relocate-source-range-key branch from 7831a6d to 346f737 Compare January 9, 2026 21:56
@jahorton jahorton force-pushed the change/web/rename-inputsource-as-pathinputprops branch from ef1b84a to cf34bf3 Compare January 9, 2026 22:21
@jahorton jahorton changed the base branch from refactor/web/relocate-source-range-key to refactor/web/manage-true-inputs-on-path January 12, 2026 20:31
@jahorton jahorton force-pushed the change/web/rename-inputsource-as-pathinputprops branch from e3b5354 to 27fc7da Compare January 12, 2026 20:31
@jahorton jahorton force-pushed the refactor/web/manage-true-inputs-on-path branch from 45ad85a to d5c496a Compare January 14, 2026 22:50
@jahorton jahorton force-pushed the change/web/rename-inputsource-as-pathinputprops branch from 27fc7da to 025c1f4 Compare January 14, 2026 23:13
@jahorton jahorton force-pushed the refactor/web/manage-true-inputs-on-path branch 2 times, most recently from b7c8da1 to 0680455 Compare January 15, 2026 21:14
@jahorton jahorton force-pushed the change/web/rename-inputsource-as-pathinputprops branch from 025c1f4 to ba97ea7 Compare January 15, 2026 21:16
@keyman-server keyman-server modified the milestones: A19S20, A19S21 Jan 16, 2026
@jahorton jahorton force-pushed the refactor/web/manage-true-inputs-on-path branch from d0ec046 to 446ac5e Compare January 22, 2026 18:32
@jahorton jahorton force-pushed the change/web/rename-inputsource-as-pathinputprops branch from fda509c to 3a613df Compare January 22, 2026 18:37
@jahorton jahorton marked this pull request as ready for review January 22, 2026 19:43
Base automatically changed from refactor/web/manage-true-inputs-on-path to epic/autocorrect January 28, 2026 23:19
@jahorton jahorton merged commit 4a4dcb9 into epic/autocorrect Jan 28, 2026
7 of 8 checks passed
@jahorton jahorton deleted the change/web/rename-inputsource-as-pathinputprops branch January 28, 2026 23:19
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change Minor change in functionality, but not new epic-autocorrect web/predictive-text/ web/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants