refactor(web): relocate definition of .sourceRangeKey to SearchQuotientSpur, SearchQuotientNode 🚂#15103
Merged
jahorton merged 2 commits intoepic/autocorrectfrom Jan 28, 2026
Conversation
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
804e5d7 to
20c6f10
Compare
jahorton
changed the base branch from
refactor/web/complex-search-space-reuse
to
refactor/web/manage-true-inputs-on-path
jahorton
force-pushed
the
refactor/web/manage-true-inputs-on-path
branch
from
807c09d to
45ad85a
Compare
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
7831a6d to
346f737
Compare
jahorton
changed the base branch from
refactor/web/manage-true-inputs-on-path
to
change/web/rename-inputsource-as-pathinputprops
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
346f737 to
a6d4180
Compare
jahorton
changed the title
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
a6d4180 to
3a19b06
Compare
jahorton
force-pushed
the
change/web/rename-inputsource-as-pathinputprops
branch
from
27fc7da to
025c1f4
Compare
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
3a19b06 to
01371c0
Compare
jahorton
force-pushed
the
change/web/rename-inputsource-as-pathinputprops
branch
from
025c1f4 to
ba97ea7
Compare
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
01371c0 to
a679ebe
Compare
jahorton
force-pushed
the
change/web/rename-inputsource-as-pathinputprops
branch
from
fda509c to
3a613df
Compare
…ntSpur, SearchQuotientNode Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/relocate-source-range-key
branch
from
cb6ffee to
cf39508
Compare
ermshiperete
approved these changes
Jan 27, 2026
web/src/engine/predictive-text/worker-thread/src/main/correction/search-quotient-spur.ts
Outdated
Show resolved
Hide resolved
| */ | ||
| get sourceRangeKey(): string { | ||
| const components: string[] = []; | ||
| const sources = this.inputSegments; |
Contributor
There was a problem hiding this comment.
(GH won't let me put a comment on the function because it didn't change, so I'm putting it here:)
Nothing new, but devin.ai noticed that inputSegments getter has side effects and mutates this.parentNode.inputSegments.
To work around we could replace parentSources.push(this.inputSource); with parentSources = [...parentSources, this.inputSource];
Contributor
Author
There was a problem hiding this comment.
I don't see any actual side-effects unless a new type with a different implementation of the getter is created (that maintains a single root instance that is reused).
The array is dynamically built on each and every call; it's not re-used in between calls and is built-up recursively. Note the common recursive root return value - a fresh, empty array is the base recursive frame for each call.
If I have two instances of SearchQuotientNode - say, A and B, with A serving as B's parent...
const bSegments = b.inputSegments;
const aSegments = a.inputSegments;
will be two separate instances.
…efactor/web/relocate-source-range-key
Base automatically changed from
change/web/rename-inputsource-as-pathinputprops
to
epic/autocorrect
January 28, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.sourceRangeKeyproperty previously defined onContextTokenwill be very useful for validating certain conditions needed for the upcomingSearchQuotientClusterimplementation ofSearchQuotientNode. AsContextTokenownsSearchQuotientNodes, and not the other way around, establishing it as a member ofSearchQuotientNodeprovides better, more direct access for the new upcoming use-case.Build-bot: skip build:web
Test-bot: skip