refactor(web): rename PendingTokenization as TransitionEdge, add doc-comments 🚂#15095
Merged
jahorton merged 2 commits intoepic/autocorrectfrom Jan 29, 2026
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
d13ebc8 to
1d113f5
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
8f1e7b1 to
6daa809
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
1d113f5 to
e97c968
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
6daa809 to
461fa4d
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
e97c968 to
0792377
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
461fa4d to
449ebec
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
3 times, most recently
from
1e13233 to
56676d8
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
56676d8 to
fd4a0d3
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
2 times, most recently
from
e340647 to
c1d580f
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
fd4a0d3 to
23fdcdc
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
c1d580f to
4c06d81
Compare
jahorton
changed the title
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
23fdcdc to
8d4aa9e
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
4c06d81 to
53ed374
Compare
jahorton
force-pushed
the
refactor/web/transform-tokenization-subset-ids
branch
from
d36203a to
fd45aa4
Compare
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
3 times, most recently
from
db9f4ed to
92d0472
Compare
jahorton
changed the title
…doc-comments Now that the SearchQuotientNode rework is stabilizing, I've finally landed on a better name for the type. PendingTokenization _directly_ correlates to outbound edges from `SearchQuotientNode` entries once processed. New doc-comments are also added documenting the relationship of `TransitionEdge` and `TokenizationSubset` to `SearchQuotientSpur` and `SearchQuotientCluster`. Admittedly, it may be wise to additionally rename `TokenizationSubset` to `TransitionCluster` (and rename the source file) to further mirror the relationship of these types... but that can always be done in a follow-up. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/rename-and-doc-pending-tokenization
branch
from
92d0472 to
cfe72f4
Compare
mcdurdin
changed the title
mcdurdin
changed the title
Base automatically changed from
refactor/web/transform-tokenization-subset-ids
to
epic/autocorrect
January 28, 2026 23:20
ermshiperete
approved these changes
Jan 29, 2026
web/src/engine/predictive-text/worker-thread/src/main/correction/context-tokenization.ts
Outdated
Show resolved
Hide resolved
web/src/engine/predictive-text/worker-thread/src/main/correction/tokenization-subsets.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the SearchQuotientNode rework is stabilizing, this feels like the best time to choose a better name for the
PendingTokenizationtype and related fields. As PendingTokenization directly correlates toSearchQuotientSpurentries once processed, I've chosen the new nameTransitionEdgeto reflect the final outbound edge of the spur. New doc-comments are also added documenting the relationship ofTransitionEdgeandTokenizationSubsettoSearchQuotientSpurand the upcomingSearchQuotientCluster.Admittedly, it may be wise to additionally rename
TokenizationSubsettoTransitionCluster(and rename the source file) to further mirror the relationship of these types... but that can always be done in a follow-up.Alternative nomenclature suggestions are welcomed.
Build-bot: skip build:web
Test-bot: skip