Skip to content

Comments

refactor(web): adds SearchQuotientNode base interface 🚂#14979

Merged
jahorton merged 4 commits intoepic/autocorrectfrom
refactor/web/search-batcher
Jan 21, 2026
Merged

refactor(web): adds SearchQuotientNode base interface 🚂#14979
jahorton merged 4 commits intoepic/autocorrectfrom
refactor/web/search-batcher

Conversation

@jahorton
Copy link
Contributor

@jahorton jahorton commented Oct 17, 2025

This new interface is being added in preparation for efficient multi-tokenization correction-search. SearchQuotientSpur has been modified to implement it, and a new type (SearchQuotientNode, previously named SearchCluster) will be added in the near future as an additional implementing type.

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 17, 2025

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(web): adds SearchBatcher interface refactor(web): adds SearchBatcher interface 🚂 Oct 17, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S14 milestone Oct 17, 2025
@jahorton jahorton force-pushed the refactor/web/search-batcher branch from f9245d7 to fac1c30 Compare October 20, 2025 15:57
@jahorton jahorton changed the base branch from refactor/web/multi-space-correction-search to feat/web/search-space-identifiers October 20, 2025 15:57
@jahorton jahorton changed the title refactor(web): adds SearchBatcher interface 🚂 refactor(web): adds SearchSpace base interface 🚂 Oct 20, 2025
@darcywong00 darcywong00 modified the milestones: A19S14, A19S15 Oct 24, 2025
@jahorton jahorton force-pushed the feat/web/search-space-identifiers branch from ff8d585 to e0ff579 Compare October 27, 2025 18:56
@jahorton jahorton force-pushed the refactor/web/search-batcher branch from fac1c30 to 9920f5e Compare October 27, 2025 19:04
@keyman-server keyman-server modified the milestones: A19S15, A19S16 Nov 8, 2025
@jahorton jahorton changed the base branch from feat/web/search-space-identifiers to refactor/web/simple-search-space-reuse November 10, 2025 18:39
@jahorton jahorton force-pushed the refactor/web/search-batcher branch from 9920f5e to 7e5d78c Compare November 10, 2025 18:40
@jahorton jahorton marked this pull request as ready for review November 12, 2025 19:59
@ermshiperete ermshiperete self-assigned this Nov 14, 2025
@ermshiperete ermshiperete removed their assignment Nov 14, 2025
@keyman-server keyman-server removed this from the A19S16 milestone Nov 22, 2025
@keyman-server keyman-server added this to the A19S17 milestone Nov 22, 2025
@keyman-server keyman-server modified the milestones: A19S17, A19S18 Dec 6, 2025
@keyman-server keyman-server modified the milestones: A19S18, A19S19 Dec 21, 2025
@keyman-server keyman-server modified the milestones: A19S19, A19S20 Jan 3, 2026
@jahorton jahorton marked this pull request as draft January 5, 2026 17:48
@jahorton jahorton force-pushed the refactor/web/simple-search-space-reuse branch from cf96a0f to c19616c Compare January 5, 2026 19:53
@jahorton jahorton force-pushed the refactor/web/search-batcher branch from 7e5d78c to 907f03c Compare January 5, 2026 20:52
@jahorton jahorton changed the title refactor(web): adds SearchSpace base interface 🚂 refactor(web): adds SearchQuotientNode base interface 🚂 Jan 7, 2026
@jahorton jahorton force-pushed the refactor/web/simple-search-space-reuse branch from 6ecc09a to 4b20187 Compare January 9, 2026 16:24
Build-bot: skip build:web
Test-bot: skip
This new interface is being added in preparation for efficient multi-tokenization correction-search.  SearchQuotientSpur has been modified to implement it, and a new type (SearchQuotientNodeImpl) will be added in the near future as an additional implementing type.

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the refactor/web/search-batcher branch from b795912 to ce3f90d Compare January 9, 2026 16:55
@jahorton jahorton marked this pull request as ready for review January 14, 2026 21:26
@keyman-server keyman-server modified the milestones: A19S20, A19S21 Jan 16, 2026
Base automatically changed from refactor/web/simple-search-space-reuse to epic/autocorrect January 21, 2026 21:57
@jahorton jahorton merged commit 74edbdc into epic/autocorrect Jan 21, 2026
7 of 8 checks passed
@jahorton jahorton deleted the refactor/web/search-batcher branch January 21, 2026 21:57
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants