forked from strata-org/Strata
-
Notifications
You must be signed in to change notification settings - Fork 0
Mutable fields #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
keyboardDrummer
wants to merge
153
commits into
forJVerify
Choose a base branch
from
mutableFields
base: forJVerify
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomadge
reviewed
Jan 19, 2026
| " | ||
|
|
||
| #guard_msgs(drop info, error) in | ||
| #eval! testInputWithOffset "T5_ProcedureCallsBoogie" program 20 processLaurelFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Core?
fabiomadge
reviewed
Jan 19, 2026
| - It has no precondition (or just `true`) | ||
| - It has exactly one output parameter (the return type) | ||
| -/ | ||
| def canBeBoogieFunction (proc : Procedure) : Bool := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be core?
### Changes 1. Move Laurel grammar from a `.lean` into a `.st` file, so it can be consumed by the `javaGen` command 1. Do not let the Laurel grammar use `fn` or `type`, since those are not needed and are not supported by `javaGen` 1. For source code positions, store byte code array offsets in the AST nodes, so that when parsing programs from Ion, these can be filled in without having access to original source files 1. Enable the Ion deserialization code to deserialize multiple files where each file has a filepath and a program AST. 1. Add a `laurelAnalyze` command to StrataMain that for now will serve as a root for Laurel related interactions. I can imagine that in the future we will introduce an analyze command that is agnostic to the dialect used. ### Testing - Laurel pipeline changes (1-3) are covered by existing tests - (4) Added a test for the newly introduced `Ion.fromIonFiles` - (5) No test added, although I've successfully used this command from aws/jverify#372 --------- Co-authored-by: Fabio Madge <fmadge@amazon.com> Co-authored-by: Fabio Madge <fabio@madge.me> Co-authored-by: Joe Hendrix <joehx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
T1_MutableFields.lean