This repository was archived by the owner on Jan 24, 2025. It is now read-only.
Added alternative cryptocurrency chooser#9
Open
TheBigS wants to merge 5 commits intokeybase:masterfrom
TheBigS:master
Open
Added alternative cryptocurrency chooser#9TheBigS wants to merge 5 commits intokeybase:masterfrom TheBigS:master
TheBigS wants to merge 5 commits intokeybase:masterfrom
TheBigS:master
Conversation
This menu will allow the user to select a cryptocurrency to generate an address for.
Bitcoin is the default, followed by Litecoin, then Dogecoin, then all the rest in alphabetical order The list of cryptocurrencies and their settings was grabbed from: https://github.com/zamgo/PHPCoinAddress
Contributor
|
This is excellent. Thank you so much for doing this. We need to review the code and we'll merge as soon as we do. It might take a few days though since it's a busy week. |
Author
|
Absolutely, take your time. I've seen you guys pop-up on HackerNews, its a big week for you. Congrats! I noticed one interface snafu after I submitted the pull request, if you want, I can fix it, otherwise you can fix it after you merge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cryptocurrency chooser to the interface. This allows a user to select different crytpo-currencies and create pub/priv keys for any of them.
The chooser has a search box for quick filtering down the currency the user is looking for.
This requires the latest pull request #2 I submitted for node-bitcoin to allow the alternative currency private keys to be imported by a wallet.