Conversation
| } | ||
| } | ||
|
|
||
| function traceRay0() // for tracing the ray path |
There was a problem hiding this comment.
Why have you removed this function?
There was a problem hiding this comment.
Sorry that was accidental, I thought that TraceRay0() was a copy of TraceRay().
There was a problem hiding this comment.
Can you reject this pull request so I can submit a new one?
I re-added the deleted code
There was a problem hiding this comment.
Changes made to a branch used for a pull request will reflect on the pull request until the pull request is successfully merged.
Hn5624
left a comment
Hn5624
left a comment
There was a problem hiding this comment.
re-added deleted code, should be good now lol.
| } | ||
| } | ||
|
|
||
| function traceRay0() // for tracing the ray path |
There was a problem hiding this comment.
Can you reject this pull request so I can submit a new one?
I re-added the deleted code
|
The mirror position is still not fixed unfortunately. |
3 participants
Sorry about that, I finally figured out how to completely work github, that and I kinda lost track of this project. Should work correctly now.
Also, I think it might be a good idea to implement a more realistic star background, I was thinking something like this. I believe it is a more efficient way to generate a background.
https://www.youtube.com/watch?v=17WoOqgXsRM&t=1s
I also have a copy in my github of that project github with keyboard controls if you want to check it out. Its under Programming Challanges/ #1 Starfield traveling