-
Notifications
You must be signed in to change notification settings - Fork 31
feat(hana) : add SAP HANA support #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fdelbrayelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suraj-0628 Hi 👋 Could you add a bunch of tests like it's done here for instance please? Thanks 🙏
plugin-jdbc-hana/src/main/java/io/kestra/plugin/jdbc/hana/package-info.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-hana/src/main/java/io/kestra/plugin/jdbc/hana/package-info.java
Outdated
Show resolved
Hide resolved
fdelbrayelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add unit tests like it's done for other dbs @suraj-0628 🙏 ?
|
Could be great if you have time to do it asap @suraj-0628 because we'll do a minor version very very soon (most likely tomorrow) 🙏 |
|
hey @fdelbrayelle i have added tests . |
plugin-jdbc-hana/src/main/java/io/kestra/plugin/jdbc/hana/Queries.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-hana/src/test/java/io/kestra/plugin/jdbc/hana/HanaCellConverterTest.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-hana/src/test/java/io/kestra/plugin/jdbc/hana/HanaConnectionInterfaceTest.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-hana/src/test/java/io/kestra/plugin/jdbc/hana/HanaDriverTest.java
Outdated
Show resolved
Hide resolved
Malaydewangan09
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think you missed adding the icons
- Maybe we could also add tests other than only failing cases, couldn't we spin it locally and setup tests?
|
@Malaydewangan09 icons ? |
|
@suraj-0628 Hi 👋 You can use this SVG icon : https://upload.wikimedia.org/wikipedia/commons/5/59/SAP_2011_logo.svg as |
|
Hi @suraj-0628 👋 What is the remaining work on this PR? After the icon, it seems ok to merge it right? |
|
Yes @fdelbrayelle the pr is ready to be merged after adding the icon . |
3e40aab to
782f484
Compare
|
@suraj-0628, did you removed the added unit tests you added 🤔? Could you add unit tests like it's done for other dbs? |
… 0.35.0 (kestra-io#736)" This reverts commit 35d9802.
fdelbrayelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suraj-0628 Could you add tests with testcontainers using this Docker image? 🙏
|
@fdelbrayelle Im looking into it ! |
|
Hey @fdelbrayelle |
|
hey @fdelbrayelle Would you be okay if I stick with the lightweight tests for now? |
|
@suraj-0628, image seems about 1.7 GB right? lets try to add tests maybe and see how complex it is? |
|
Hey @Malaydewangan09 👋🏻 |
closes #704
Summary
This PR adds support for SAP HANA to the Kestra JDBC plugin suite by introducing a new subplugin: plugin-jdbc-hana.
It provides full connectivity to SAP HANA databases using the official SAP HANA JDBC driver (ngdbc.jar), enabling users to execute SQL queries, run multiple statements, and use poll-based triggers — following the same structure and conventions as existing JDBC subplugins (DB2, Oracle, PostgreSQL, etc.) .
Key Features
✅ New SAP HANA JDBC Subplugin
Implements a complete SAP HANA JDBC integration consistent with the architecture of all existing JDBC database plugins.
Includes the following new components:
HanaCellConverter.java
HanaConnectionInterface.java
Query.java
Queries.java
Trigger.java
package-info.java
✅ Driver & Connection Handling
Uses the official SAP HANA JDBC driver:
com.sap.db.jdbc.Driver
Supports the standard HANA JDBC URL format:
jdbc:sap://:/?databaseName=
Connection options supported:
Host
Port
Database name
Username / Password
SSL enablement
Login timeout
✅ SAP HANA-specific Cell Conversion
Added HanaCellConverter for type-safe conversion of standard HANA data types
(e.g., NVARCHAR, SHORTTEXT, TIMESTAMP, BLOB, CLOB, etc.)
✅ Full Feature Parity With Other JDBC Plugins
Query → For single SQL execution
Queries → For multiple SQL statements
Trigger → Polls a SQL query and triggers flows when results are returned
Driver registration prevents duplicates (same as DB2 plugin)
Uses AbstractJdbcQuery / AbstractJdbcQueries / AbstractJdbcTrigger exactly as other JDBC subplugins do