Conversation
Dockerfile — 2 changes:
Added curl and unzip to the apk add line (line 9)
Added the snapweb download RUN step (lines 11-17) with unzip -o to force overwrite and avoid the interactive prompt that caused the original build failure
Workflow YAML — 2 changes:
Line 71: Added ref: ${{ github.ref }} to the build job's checkout — ensures it picks up the new commit if check-update pushed a version bump
Lines 74-80: Replaced the Dockerfile-parsing meta_version step with one that uses needs.check-update.outputs.version directly — more robust and avoids reading a potentially stale Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Github action yaml file to check the Alpine snapserver pkg, test if current version matches, and if newer version exists, update the Dockerfile SNAPCAST_VERSION arg, then build the Dockerfile, and finally push to GHCR