Check the environment to avoid building sleef #258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we typically build with `pip install ...`, we do not have the ability to turn off building Sleef with `-DCMAKE_BUILD_SLEEF=OFF`. This change checks the environment to see whether `BUILD_SLEEF=OFF`, avoiding this dependency.
alexbaden
requested changes
Jan 29, 2026
Contributor
alexbaden
left a comment
alexbaden
left a comment
There was a problem hiding this comment.
We're not using it right now - let's just disable it in the build?
Contributor
Author
|
You mean |
Contributor
Author
|
If we're not going to build this in CI then it will be unlikely to work if/when we turn it back on. In that case, we should probably just remove it for now. We can always resurrect it from Git if at some point we need it and it will still be about the same amount of work to get it working again. |
Contributor
|
Just set it to OFF by default to resolve your build problems and then we can figure out what to do with it once we have better dot performance. |
abrown
added a commit
to abrown/triton-cpu
that referenced
this pull request
Jan 29, 2026
This follows from the discussion in kernelize-ai#258.
abrown
added a commit
that referenced
this pull request
Jan 29, 2026
This follows from the discussion in #258.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we typically build with
pip install ..., we do not have the ability to turn off building Sleef with-DCMAKE_BUILD_SLEEF=OFF. This change checks the environment to see whetherBUILD_SLEEF=OFF, avoiding this dependency.