Skip to content

Conversation

@anchalsahani
Copy link

Summary

This PR improves the resilience of the testimonials section ("What our community thinks") by fixing broken X/Twitter avatars and restoring consistent linking behavior. The work contributes toward resolving [#3621], where several profile links were broken and some tweets did not render properly.

Issue Reference

  • Related: [#3621] — “Some links in ‘What our community thinks’ section are not working”

Changes

  • Added fallback avatar for missing or invalid external URLs
  • Updated broken X/Twitter profile and tweet links
  • Applied proxy-based image handling for external avatars
  • Added lazy loading for non-critical images to reduce layout impact
  • Reduced layout shift by fixing dimensions for avatars in testimonial cards
  • Improved UX for degraded network scenarios

Motivation

Remote assets from X/Twitter frequently return redirects, HTML payloads, or CDN error codes (e.g., 403). These failures result in blank avatar spaces, broken links, and layout shifts that degrade Lighthouse metrics (CLS, INP) and visual clarity. The modifications in this PR aim to achieve graceful degradation and reduce dependency on network conditions and external CDNs for critical rendering.

Testing & Observations

Local verification was performed under the following cases:

Scenario Expected Observed
Valid avatar URLs Avatar displays Success
Invalid avatar URLs Fallback avatar renders Success
Offline / throttled network No visual breakage Success
Broken profile links Redirects fixed Success
Lighthouse (local) No perceptible regression Stable

No changes were made to backend, routing logic, or build pipeline.

Visual Comparison (Before / After)

Before (broken avatars / URLs)
image
After (fallback + corrected links)
image

Notes

The outcome contributes to the fix for [#3621], but does not modify testimonial source content or editorial selection. Feedback from maintainers is welcome regarding alternative approaches (e.g., caching avatars, sanitizing URLs at build time, or fully decoupling external testimonials from CDN behavior).

@anchalsahani anchalsahani force-pushed the fix/fallback-avatars branch 3 times, most recently from 1f5885c to 1b32146 Compare January 27, 2026 12:42
@anchalsahani anchalsahani changed the title Fix issue [#3621] broken X/Twitter avatars & links in testimonials by adding fallback image handling Fix #3621 broken X/Twitter avatars & links in testimonials by adding fallback image handling Jan 27, 2026
@amaan-bhati amaan-bhati self-requested a review January 27, 2026 17:25
Copy link
Member

@amaan-bhati amaan-bhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anchalsahani THanks for raising this pr, can you please take a look at the build failures before i try and review this pr locally?

…en avatars

Signed-off-by: Anchal Sahani <sahanianchal7@gmail.com>
Signed-off-by: Anchal Sahani <sahanianchal7@gmail.com>
@anchalsahani
Copy link
Author

Hi @amaan-bhati, thanks for checking!

I’ve fixed the build issue and updated the PR. Please let me know if you still see any failures on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants