-
Notifications
You must be signed in to change notification settings - Fork 191
chore: configure environment and update image domains #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mishraa-G Thanks for raising the pr, before i try and review everything on the local, can you please add some preview and checks in the form of screenshots. This would add more context to the pr.
Sure @amaan-bhati , Ive atached a screenshot where on launching locally gives deprecation warnings in the console. And i've also attached screenshot of after the fix where there is no deprecation warnings in the console also a screen shot of blog running locally and still loading all the images perfectly after the fix.
before
after
blog thumbnails and external images are loading correctly |
| "resolved": "https://registry.npmjs.org/@codemirror/view/-/view-6.34.1.tgz", | ||
| "integrity": "sha512-t1zK/l9UiRqwUNPm+pdIT0qzJlzuVckbTEMVNFhfWkGiBQClstzg+78vedCvLSX0xJEZ6lwZbPpnljL7L6iwMQ==", | ||
| "license": "MIT", | ||
| "peer": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mishraa-G Please update the pr description adding explanation for the changes added in the package-lock.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh, thanks for catching that! I ran npm install locally to set up the project and it must have auto-updated the lockfile. That was unintentional. I will revert package-lock.json now to keep this PR focused solely on the config fix if thats okay with you?



chore: configure environment and update image domains
Related Tickets & Documents
Fixes: #3635
Description
images.remotePatternsinstead of the deprecatedimages.domains.Changes
next.config.jsto replaceimages.domainsarray withimages.remotePatternsforkeploy.io,wp.keploy.io,secure.gravatar.com, andpbs.twimg.com.package-lock.jsonvianpm installto ensure dependency consistency.Type of Change
Testing
npm run devand verified the application starts without errors onlocalhost:3000./blogand renders the homepage content successfully including images.npm run buildto confirm there are no compile-time errors.Demo
Environment and Dependencies
Checklist