Open
Conversation
Don't let background image get out of visibility.
Author
|
It's been months since @bcole808 and my PR (January) so sorry to ask this but, are you still managing this library? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fully move background image within container limits.
Using "bound: false" and "background-repeat: no-repeat" you can move the image out of sight.
Solution
Limit background movement to prevent getting out of sight.
Additionally adding an inner frame to constraint how close to the borders can the background get, allowing the image to be always be visible at least those pixels
Implementation
New option "frame" indicates number of pixels to limit background movement. Only used when "bound: true"
Frame option is best viewed with "background-repeat: no-repeat"
Calculate boundaries for background position when "bound: true" and a frame is provided so you can move background freely inside container boundaries limited by frame.
Extra
The ability to trigger drag from inner elements (in the example from <p> elements) is desirable in some situations. Added a "propagate" option for this