Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| const zkAccountToSettle: ZkAccount = { | ||
| ...currentZkAccount, | ||
| value: newBalance, | ||
| type: accountType, |
There was a problem hiding this comment.
Unused accountType variable after refactor to helper
Low Severity
The accountType variable is now dead code. It was previously consumed when constructing zkAccountToSettle inline, but that logic was replaced by buildPersistedTerminalTradeAccount, which derives the type internally. The variable is assigned but never read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Touches trade cleanup and wallet transfer flows that move funds between ZK subaccounts and the funding/trading accounts; incorrect amounts or state updates could block recovery or transfer the wrong balance.
Overview
Fixes recovery for terminal trade subaccounts (e.g.
SETTLED/CANCELLED) by persisting a recoverableZkAccountstate (type + roundedavailableMargin) before queued cleanup attempts to merge funds back into the master trading account.Updates the wallet’s “Transfer to Funding” flow to compute the recovery transfer amount from terminal trade
availableMargin(instead of stalezkAccount.value) and surfaces previously silent failures with explicit error toasts.Adds
lib/utils/tradeRecovery.tshelpers plus focused unit tests covering terminal-account persistence, manual recovery amount selection, and deduped cleanup-failure notifications.Written by Cursor Bugbot for commit 77da21b. This will update automatically on new commits. Configure here.