Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
astral-sh/setup-uv@v7astral-sh/setup-uv@v7 exclusively
astral-sh/setup-uv@v7 exclusivelyuv exclusively
`activate-environment: true` is the killer feature of newer `astral-sh/setup-uv@v7` that significantly improves usability.
uv exclusivelyuv exclusively and accomodate PyPy
uv exclusively and accomodate PyPyuv exclusively and accommodate PyPy
uv exclusively and accommodate PyPyuv exclusively
|
looks good! |
| # TODO: Accommodate PyPy as installed by `uv`, it emits spurious output on stdout before the version number. | ||
| # AssertionError: assert '(_common_types_metatype, 9088, 128, 128)\n(cython_function_or_method, 157568, 128, 128)\n3.6.0' == '3.6.0' | ||
| lines = [line.strip() for line in stdout.splitlines() if line.strip()] | ||
| assert lines, "Expected version output on stdout" | ||
| assert lines[-1] == __version__ |
There was a problem hiding this comment.
PyPy as installed by GHA's actions/setup-python doesn't do that.
/cc @charliermarsh
About
That's just maintenance. In this case, streamline the CI configuration for improved ergonomics and future proofing, see GH-605.
Details
activate-environment: trueof newerastral-sh/setup-uv@v7is the killer feature here, which wasn't available before.cache-dependency-glob: pyproject.tomlisn't needed, because the recipe already employs an excellent default configuration that includes this and other project metadata files.test_cliwere needed because of a different PyPy version installed bysetup-uv. This will yield a report to Astral maintainers, unrelated to this patch.