DRY up common fields across Injector modules via __using__ macro#14
Merged
kenichirow merged 4 commits intomainfrom Feb 17, 2026
Merged
DRY up common fields across Injector modules via __using__ macro#14kenichirow merged 4 commits intomainfrom
kenichirow merged 4 commits intomainfrom
Conversation
Replace Faultex.Injector protocol with a regular module that provides a __using__ macro to generate defstruct with shared fields. Each injector now uses `use Faultex.Injector, fields: [...]` instead of duplicating 7 common fields. Remove all defimpl blocks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
use Faultex.Injector now only injects @__fields__ module attribute, following Elixir convention that `use` is for behavior injection rather than struct definition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Faultex.Injectorprotocol with a regular module providing a__using__macrodefstructwith 7 shared fields (:id,:disable,:host,:method,:path,:headers,:percentage) plus module-specific fieldsdefimpl Faultex.Injectorblocks from each injector moduleinject/1viainjector.__struct__.inject(injector)instead of protocolCloses #43