fix(phase12): restore proofd closure boundary for official closure#60
fix(phase12): restore proofd closure boundary for official closure#60
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b230a355ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
userspace/proofd/src/lib.rs
Outdated
| binding | ||
| .and_then(|value| value.surface_local_path_id.clone()) | ||
| .unwrap_or_else(|| "reports/replay_report.json".to_string()), | ||
| .unwrap_or_else(|| replay_report_relative_path().display().to_string()), |
There was a problem hiding this comment.
Using replay_report_relative_path().display().to_string() makes the default surface_local_path_id platform-dependent (reports\\replay_report.json on Windows instead of reports/replay_report.json). That value is included in companion flow event canonical hashing (compute_companion_flow_event_id serializes the full event payload), so the same logical verification run can produce different event_id values across operating systems, undermining deterministic artifacts and cross-environment comparability.
Useful? React with 👍 / 👎.
1 participant
Summary
Local Evidence
Remote Confirmation
Notes