Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This submission modernizes the i2c library by refactoring the public API to use async/await and Promises. This makes the code cleaner, easier to use, and more in line with modern JavaScript practices. The C++ addon has also been updated to be compatible with these changes.


PR created automatically by Jules for task 583348703266940890 started by @kelly

This commit refactors the entire library to use a modern, Promise-based API with `async/await`. This simplifies the codebase and improves the developer experience.

Key changes:
- All public methods in `lib/i2c.js` now return Promises.
- The C++ addon has been updated to support callbacks, making it compatible with `util.promisify`.
- Redundant `setAddress` calls have been removed from the JavaScript layer and are now handled correctly in the asynchronous flow.
- A new example file, `examples/simple.js`, has been added to demonstrate the new API.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

This commit updates the `README.md` and all examples to use the new `async/await`-based API. This makes the documentation and examples clearer, more accurate, and consistent with the modernized codebase.

Key changes:
- The `README.md` has been updated with `async/await` usage examples.
- The `accelerometer` and `blinkm` examples have been refactored to use the new API.
- The obsolete "Node 0.11 and under" section has been removed from the `README.md`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant