Skip to content

fix: actually implement rendered config map and secrets#177

Merged
talboren merged 3 commits intokeephq:mainfrom
ianmuge:fix/actual-render-config-map-and-secrets
Jan 18, 2026
Merged

fix: actually implement rendered config map and secrets#177
talboren merged 3 commits intokeephq:mainfrom
ianmuge:fix/actual-render-config-map-and-secrets

Conversation

@ianmuge
Copy link
Contributor

@ianmuge ianmuge commented Aug 26, 2025

Closes # N/A

📑 Description

This implements and extends the envRender environment variables for both the frontend and backend to provision corresponding configmaps and secrets

ION:

  • fixed a mismatched reference to the topology spread in the frontend

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@ianmuge ianmuge requested a review from talboren as a code owner August 26, 2025 17:11
@ianmuge ianmuge changed the title Fix/actual render config map and secrets fix: actually implement rendered config map and secrets Aug 26, 2025
@ianmuge
Copy link
Contributor Author

ianmuge commented Oct 2, 2025

@shahargl could I please get a review on this?

@ianmuge
Copy link
Contributor Author

ianmuge commented Jan 18, 2026

@talboren any chance of this being reviewed?

@talboren
Copy link
Member

@talboren any chance of this being reviewed?

We're having some trouble with the image building process for Keep. Approving, but have not tested it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements the envRender configuration option for both frontend and backend components to provision ConfigMaps alongside the existing envRenderSecret functionality for Secrets. It also fixes a bug where the frontend deployment incorrectly referenced backend topology spread constraints.

Changes:

  • Added envRender configuration option for backend and frontend to support templated ConfigMap creation
  • Created new template files frontend-configs.yaml and backend-configs.yaml to provision ConfigMaps and Secrets
  • Fixed topology spread constraints reference in frontend deployment to use frontend values instead of backend values
  • Added checksum annotations for envRender and envRenderSecret to trigger pod restarts on configuration changes

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
charts/keep/values.yaml Added envRender configuration options for both backend and frontend
charts/keep/templates/frontend.yaml Added envRender support in envFrom, checksum annotations, and fixed topology spread constraints bug
charts/keep/templates/frontend-configs.yaml New file that creates ConfigMap and Secret resources from envRender and envRenderSecret values
charts/keep/templates/backend.yaml Added envRender support in envFrom and checksum annotations
charts/keep/templates/backend-configs.yaml New file that creates ConfigMap and Secret resources from envRender and envRenderSecret values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# -- Sensible environment variables will be rendered as a new secret object; escape {{ in secret values to avoid Helm interpretation.
envRenderSecret: {}

# -- Sensible environment variables will be rendered as a new configmap object; escape {{ in secret values to avoid Helm interpretation.
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "escape {{ in secret values to avoid Helm interpretation" but this is for a ConfigMap (envRender), not for secrets. ConfigMaps should contain non-sensitive data, so the comment should be updated to reference "configmap values" instead of "secret values". This same comment appears correctly for envRenderSecret above.

Suggested change
# -- Sensible environment variables will be rendered as a new configmap object; escape {{ in secret values to avoid Helm interpretation.
# -- Sensible environment variables will be rendered as a new configmap object; escape {{ in configmap values to avoid Helm interpretation.

Copilot uses AI. Check for mistakes.
# -- Name of the secret to include
envFromSecret: ""

# -- Sensible environment variables will be rendered as a new configmap object; escape {{ in secret values to avoid Helm interpretation.
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "escape {{ in secret values to avoid Helm interpretation" but this is for a ConfigMap (envRender), not for secrets. ConfigMaps should contain non-sensitive data, so the comment should be updated to reference "configmap values" instead of "secret values".

Suggested change
# -- Sensible environment variables will be rendered as a new configmap object; escape {{ in secret values to avoid Helm interpretation.
# -- Sensible environment variables will be rendered as a new configmap object; escape {{ in configmap values to avoid Helm interpretation.

Copilot uses AI. Check for mistakes.
@talboren talboren merged commit 16eb80b into keephq:main Jan 18, 2026
9 of 15 checks passed
@ianmuge
Copy link
Contributor Author

ianmuge commented Jan 18, 2026

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants