Support new CSV format #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hm, good catch! Looks good, just fix the tests please. |
Owner
|
ofxstatement-transferwise-1.2.0 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5, the CSV columns mapping was updated to take into account the new third column
Date Timeof the CSV file, but while building the memo in_make_memo, we are still using the wrong mapping.This MR updates the code to correctly map the CSV columns by grabbing values based on the column names instead of the column indexes. Additionally, reads the
trntypefrom the newTransaction Typecolumn anddatefromDate Time.Uses snapshot testing to easily assert changes on the logic.