feat(highlights): position-based text highlighting#340
Draft
kdroidFilter wants to merge 1 commit intomasterfrom
Draft
feat(highlights): position-based text highlighting#340kdroidFilter wants to merge 1 commit intomasterfrom
kdroidFilter wants to merge 1 commit intomasterfrom
Conversation
d1e0ed4 to
b5e14a5
Compare
- Add character offset tracking for precise highlight positioning - Preserve highlight position when toggling nikud/taamim visibility - Improve highlight color picker UI in context menu - Use proper menu item colors for icons and text
c88c85f to
ae66dda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LineTextRegistryto track visible line content for position lookupTechnical Details
UserHighlight(lineId, startOffset, endOffset, color)applyUserHighlightsto use position offsetsNote
Highlights are currently in-memory only and will be lost when the app closes.
Follow-up: Persistence Implementation
To persist highlights to
UserSettingsDb, the following changes are needed:1. Create
UserHighlights.sqLocation:
SeforimApp/src/commonMain/sqldelight/io/github/kdroidfilter/seforimapp/db/2. Create
HighlightRepository.ktFollow the pattern of
CategoryDisplaySettingsStore:UserSettingsDbColor↔Int(usingcolor.toArgb()andColor(argb))3. Modify
HighlightStore.ktHighlightRepositoryaddHighlight()/removeHighlight()Test plan