Add recursive CTE queries for TOC ancestor path and leaf descent#55
Closed
kdroidFilter wants to merge 1 commit intomasterfrom
Closed
Add recursive CTE queries for TOC ancestor path and leaf descent#55kdroidFilter wants to merge 1 commit intomasterfrom
kdroidFilter wants to merge 1 commit intomasterfrom
Conversation
Add selectAncestorPath and selectFirstLeafUnder CTE queries to replace N-query loops for building TOC paths to root and finding first leaf entries. - Add getAncestorPath() and getFirstLeafTocId() methods to SeforimRepository - Add getAncestorPath() to LineSelectionRepository interface - Add SelectAncestorPath.toModel() extension for TocEntry conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectAncestorPathCTE query to retrieve the full ancestor chain of a TOC entry in a single query (replaces N×getTocEntry()loop)selectFirstLeafUnderCTE query to find the first leaf entry under a TOC node in a single query (replaces N×getTocChildren()recursion)getAncestorPath()andgetFirstLeafTocId()methods toSeforimRepositorygetAncestorPath()toLineSelectionRepositoryinterfaceSelectAncestorPath.toModel()extensionTest plan
selectAncestorPathreturns correct root-to-leaf path for deeply nested TOC entriesselectFirstLeafUnderreturns the correct first leaf for nodes with varying depth:SeforimLibrary:dao:compileKotlinJvm— confirms SQLDelight generation + DAO compilation