Skip to content

Feat: FE - txType 선택 UI 및 TypeTag 복구#227

Merged
kdh-92 merged 1 commit intomainfrom
feat/fe-enhancements
Apr 9, 2026
Merged

Feat: FE - txType 선택 UI 및 TypeTag 복구#227
kdh-92 merged 1 commit intomainfrom
feat/fe-enhancements

Conversation

@kdh-92
Copy link
Copy Markdown
Owner

@kdh-92 kdh-92 commented Apr 9, 2026

거래 생성 시 지출/수입/환불 선택 + TypeTag 컴포넌트 복구

Summary by CodeRabbit

변경 사항

  • Chores
    • 지속적 통합 워크플로우의 테스트 실행 설정을 업데이트했습니다. 배포 파이프라인이 더욱 효율적으로 작동합니다.

Vitest exits with code 1 when no test files found. Use --passWithNoTests
flag to allow CI to pass until test files are added.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

GitHub Actions 워크플로우에서 프론트엔드 테스트 명령을 npm test에서 npx vitest run --passWithNoTests로 변경하여 테스트 러너를 전환하고 테스트가 없을 때도 성공하도록 설정했습니다.

Changes

Cohort / File(s) Summary
CI 워크플로우 테스트 단계
.github/workflows/ci.yml, .github/workflows/main.yml
테스트 실행 명령이 npm test에서 npx vitest run --passWithNoTests로 변경되어 Vitest를 직접 실행하고 테스트 미발견 시에도 성공하도록 설정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 테스트 러너를 바꾸니 반가워,
Vitest가 옹알거리며 달려와,
테스트 없어도 괜찮다고 말하네,
워크플로우는 더 유연해지고,
배포의 길은 매끄러워졌네! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning PR 제목은 '거래 유형 선택 UI 및 TypeTag 복구'를 설명하지만, 실제 변경사항은 Vitest 테스트 러너 구성 변경(CI 워크플로우)입니다. PR 제목을 실제 변경사항을 반영하도록 수정하세요. 예: 'CI: Configure Vitest with passWithNoTests flag for frontend tests' 또는 제목과 변경사항을 일치시키기 위해 커밋 내용을 확인하세요.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/fe-enhancements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kdh-92 kdh-92 merged commit 707cf8a into main Apr 9, 2026
1 of 3 checks passed
@kdh-92 kdh-92 deleted the feat/fe-enhancements branch April 9, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants