Support passing options to https #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`url.parse("http://foo.com:444/bar").hostname` returns `"foo.com:444"`,
which causes `validate` to make an invalid call to `https`.
This permits us to set values like 'rejectUnauthorized'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to node 0.10, the https module defaults to checking SSL certs and throwing an error if it encounters a self-signed cert. Our CAS is hosted on a server with such a cert, so we need a way to disable this checking. I figured it would be best to just permit the using modules to insert other options as well.
(This request includes other new commits from master, but you can just cherry-pick 330c84c)