Feature2 by kber-ps · Pull Request #2 · kber-ps/ghdemo

kber-ps · 2025-04-28T16:19:37Z

No description provided.

github-actions · 2025-04-28T16:19:51Z

clock.c

+void display_time_diff(time_t time1, time_t time2)
+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);


[clang-format-pr] _{reported by reviewdog 🐶}

Suggested change

void display_time_diff(time_t time1, time_t time2)

{

char buf[BUF_SIZE];

time_t the_time = time2 - time1;

char t = ctime(&the_time);

sprintf(buf, "\n\nTime difference is %s\n\n", t);

print_string(buf);

void display_time_diff(time_t time1, time_t time2) {

char buf[BUF_SIZE];

time_t the_time = time2 - time1;

char t = ctime(&the_time);

sprintf(buf, "\n\nTime difference is %s\n\n", t);

print_string(buf);

github-actions · 2025-04-28T16:19:51Z

clock.c

+void display_time_diff2(time_t time1, time_t time2)
+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);


[clang-format-pr] _{reported by reviewdog 🐶}

Suggested change

void display_time_diff2(time_t time1, time_t time2)

{

char buf[BUF_SIZE];

time_t the_time = time2 - time1;

char t = ctime(&the_time);

sprintf(buf, "\n\nTime difference is %s\n\n", t);

print_string(buf);

void display_time_diff2(time_t time1, time_t time2) {

char buf[BUF_SIZE];

time_t the_time = time2 - time1;

char t = ctime(&the_time);

sprintf(buf, "\n\nTime difference is %s\n\n", t);

print_string(buf);

github-actions · 2025-04-28T16:19:52Z

clock.c

[clang-format-pr] _{reported by reviewdog 🐶}

ghdemo/clock.c

Lines 26 to 33 in 2a6c4e5

void display_time_diff_from_now(time_t old_time)

{

char buf[BUF_SIZE];

time_t the_time = old_time - time(NULL);

char t = ctime(&the_time);

sprintf(buf, "\n\nCurrent Time and Date is %s\n\n", t);

print_string(buf);

clock.c

+ * Print the time diff from current time
 */
-void display_time_diff(time_t old_time)
+void display_time_diff_from_now(time_t old_time)


clock.c

+ * Print the time diff from current time
 */
-void display_time_diff(time_t old_time)
+void display_time_diff_from_now(time_t old_time)


clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff(time_t time1, time_t time2)


clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff(time_t time1, time_t time2)


clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff(time_t time1, time_t time2)


clock.c

+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);


clock.c

+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);


clock.c

+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);


clock.c

+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);


clock.c

+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);


github-actions · 2025-04-28T16:42:20Z

clock.c

+void display_time_diff3(time_t time1, time_t time2)
+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);


[clang-format-pr] _{reported by reviewdog 🐶}

Suggested change

void display_time_diff3(time_t time1, time_t time2)

{

char buf[BUF_SIZE];

time_t the_time = time2 - time1;

char t = ctime(&the_time);

sprintf(buf, "\n\nTime difference is %s\n\n", t);

print_string(buf);

void display_time_diff3(time_t time1, time_t time2) {

char buf[BUF_SIZE];

time_t the_time = time2 - time1;

char t = ctime(&the_time);

sprintf(buf, "\n\nTime difference is %s\n\n", t);

print_string(buf);

github-actions · 2025-04-28T16:42:20Z

clock.c

+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);
+}
+


[clang-format-pr] _{reported by reviewdog 🐶}

Suggested change

clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff3(time_t time1, time_t time2)


clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff3(time_t time1, time_t time2)


clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff3(time_t time1, time_t time2)


clock.c

+void display_time_diff3(time_t time1, time_t time2)
+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;


clock.c

+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);


clock.c

+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);


clock.c

+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);


clock.c

+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);


clock.c

+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);


github-actions · 2025-04-28T16:47:24Z

clock.c

+ * Print the time diff from current time
 */
-void display_time_diff(time_t old_time)
+void display_time_diff_from_now(time_t old_time)


🚫 [C/C++test] <MISRAC2012-RULE_8_4-a> _{reported by reviewdog 🐶}
Prototype of function 'display_time_diff_from_now' does not precede function definition

github-actions · 2025-04-28T16:47:24Z

clock.c

+ * Print the time diff from current time
 */
-void display_time_diff(time_t old_time)
+void display_time_diff_from_now(time_t old_time)


🚫 [C/C++test] <MISRAC2012-RULE_21_10-c> _{reported by reviewdog 🐶}
The 'time_t' identifier should not be used

github-actions · 2025-04-28T16:47:25Z

clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff(time_t time1, time_t time2)


🚫 [C/C++test] <MISRAC2012-RULE_8_4-a> _{reported by reviewdog 🐶}
Prototype of function 'display_time_diff' does not precede function definition

github-actions · 2025-04-28T16:47:25Z

clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff(time_t time1, time_t time2)


🚫 [C/C++test] <MISRAC2012-RULE_21_10-c> _{reported by reviewdog 🐶}
The 'time_t' identifier should not be used

github-actions · 2025-04-28T16:47:25Z

clock.c

+/*
+ * Print the time difference
+ */
+void display_time_diff(time_t time1, time_t time2)


🚫 [C/C++test] <MISRAC2012-RULE_21_10-c> _{reported by reviewdog 🐶}
The 'time_t' identifier should not be used

github-actions · 2025-04-28T16:47:27Z

clock.c

+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);


⚠️ [C/C++test] <MISRAC2012-RULE_11_4-a> _{reported by reviewdog 🐶}
Pointer to object type 'char *' should not be converted to integral type 'char'

github-actions · 2025-04-28T16:47:27Z

clock.c

+{
+    char buf[BUF_SIZE];
+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);


🚫 [C/C++test] <MISRAC2012-RULE_21_10-b> _{reported by reviewdog 🐶}
Usage of 'ctime' function is not allowed

github-actions · 2025-04-28T16:47:27Z

clock.c

+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);


🚫 [C/C++test] <MISRAC2012-RULE_21_6-a> _{reported by reviewdog 🐶}
The 'sprintf' library function should not be used

github-actions · 2025-04-28T16:47:27Z

clock.c

+    time_t the_time = time2 - time1;
+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);


🚫 [C/C++test] <MISRAC2012-RULE_17_7-a> _{reported by reviewdog 🐶}
Unused function's "sprintf" return value

github-actions · 2025-04-28T16:47:27Z

clock.c

+    char t = ctime(&the_time);
+
+    sprintf(buf, "\n\nTime difference is %s\n\n", t);
+    print_string(buf);


🚫 [C/C++test] <MISRAC2012-RULE_17_7-a> _{reported by reviewdog 🐶}
Unused function's "print_string" return value

kber-ps added 5 commits April 28, 2025 13:11

pr test

b171199

pr test 2

bd7ee0d

permissions

540b7cc

permissions

fbac3fe

test

2a6c4e5

github-actions bot reviewed Apr 28, 2025

View reviewed changes

kber-ps added 2 commits April 28, 2025 18:24

test2

1a34544

test3

1a98cd6

github-advanced-security bot found potential problems Apr 28, 2025

View reviewed changes

kber-ps added 2 commits April 28, 2025 18:29

test3

f0b7838

terst4

0815acd

github-actions bot reviewed Apr 28, 2025

View reviewed changes

github-advanced-security bot found potential problems Apr 28, 2025

View reviewed changes

test6

5db4629

github-actions bot reviewed Apr 28, 2025

View reviewed changes

	void display_time_diff_from_now(time_t old_time)
	{
	char buf[BUF_SIZE];
	time_t the_time = old_time - time(NULL);
	char t = ctime(&the_time);

	sprintf(buf, "\n\nCurrent Time and Date is %s\n\n", t);
	print_string(buf);

Conversation

kber-ps commented Apr 28, 2025

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check warning

Check failure

Check failure

Check failure

Check failure

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check warning

Check failure

Check failure

Check failure

Check failure

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant