refactor(runtime-go): introduce Runtime-based parsing and module fetching
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Excluded from list `GOCACHE`, `GOCACHEPROG`. - Moved commented-out environment variables to the bottom of the exclusion list for better readability. - Adjusted formatting for consistency.
…tching - Replaced global `parse` and `fetchModule` functions with `Runtime` methods. - Added `goEnv` helper to manage and override Go environment variables. - Introduced `goCacheDir` for versioned Go cache management. - Updated tests to use the new `Runtime` helpers.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 29.56% 31.75% +2.18%
==========================================
Files 19 20 +1
Lines 2212 1751 -461
==========================================
- Hits 654 556 -98
+ Misses 1491 1126 -365
- Partials 67 69 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replaced `goCacheDir` string with `optional.Val` to handle optional cache directory paths. - Updated `New` constructor to accept an `optional.Val` for `goCacheDir`. - Adjusted `goEnv` logic to include `GOCACHE` only if `goCacheDir` is set. - Simplified tests with `optional.Empty` and `optional.New` usage.
- Consolidated `goCache.Get` and directory creation steps into a single conditional. - Replaced explicit permissions with `fsh.DefaultDirPerm` for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(runtime-go): introduce
Runtime-based parsing and module fetchingparseandfetchModulefunctions withRuntimemethods.goEnvhelper to manage and override Go environment variables.goCacheDirfor versioned Go cache management.Runtimehelpers.