Skip to content
This repository was archived by the owner on Jul 25, 2020. It is now read-only.

fixing pherialize long int#7

Open
yhuang8 wants to merge 3 commits intokayahr:masterfrom
yhuang8:yh-fixing-pherialize-long-int
Open

fixing pherialize long int#7
yhuang8 wants to merge 3 commits intokayahr:masterfrom
yhuang8:yh-fixing-pherialize-long-int

Conversation

@yhuang8
Copy link

@yhuang8 yhuang8 commented Sep 12, 2014

  • Unserialize integer falls to try long int
  • fix serialize long int which should be type i, d is for double

@buildhive
Copy link

Klaus Reimer » pherialize #7 SUCCESS
This pull request looks good
(what's this?)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to eliminate duplication you can extract this.data.substring(this.pos + 2, pos) before try block.

@platan
Copy link

platan commented Oct 3, 2014

Nice fix. I'd like to see this changes in released as a new version.

@buildhive
Copy link

Klaus Reimer » pherialize #9 SUCCESS
This pull request looks good
(what's this?)

@mspiegel
Copy link

Isn't there an issue with this pull request in that on some platforms the PHP integer type is 32 bits and on other platforms it is 64 bits? Forgive me ahead of time my knowledge of PHP is limited.

@yhuang8
Copy link
Author

yhuang8 commented Oct 25, 2014

hmm, I kinda don't think it will, because it is for unserializing php to java. Java integer is 32 bit. Even if certain PHP platform uses 64 bit integer, when serializing it to java, it should convert it to either Int or Long accordingly. Let me know your thoughts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants