Conversation
|
Klaus Reimer » pherialize #7 SUCCESS |
There was a problem hiding this comment.
In order to eliminate duplication you can extract this.data.substring(this.pos + 2, pos) before try block.
|
Nice fix. I'd like to see this changes in released as a new version. |
|
Klaus Reimer » pherialize #9 SUCCESS |
|
Isn't there an issue with this pull request in that on some platforms the PHP integer type is 32 bits and on other platforms it is 64 bits? Forgive me ahead of time my knowledge of PHP is limited. |
|
hmm, I kinda don't think it will, because it is for unserializing php to java. Java integer is 32 bit. Even if certain PHP platform uses 64 bit integer, when serializing it to java, it should convert it to either Int or Long accordingly. Let me know your thoughts. |
i,dis for double