Implementing delete volume queue & prioritization#18
Open
kavyamani596 wants to merge 5 commits intotask_support_for_resourcesfrom
Open
Implementing delete volume queue & prioritization#18kavyamani596 wants to merge 5 commits intotask_support_for_resourcesfrom
kavyamani596 wants to merge 5 commits intotask_support_for_resourcesfrom
Conversation
kavyamani596
changed the base branch from
BRUCE-7215
to
task_support_for_resources
kavyamani596
changed the title
kavyamani596
requested review from
amar-shalgar,
ashraf-vazeer,
hemkapoor and
mohamed-shahid-afrid
kavyamani596
requested review from
amar-shalgar,
ashraf-vazeer,
chauberahul1993,
hemkapoor and
mohamed-shahid-afrid
and removed request for
amar-shalgar,
ashraf-vazeer,
hemkapoor and
mohamed-shahid-afrid
chauberahul1993
approved these changes
Mar 24, 2023
mohamed-shahid-afrid
approved these changes
Mar 24, 2023
AngithCJ
reviewed
Mar 24, 2023
| DevicePassword: common.DecryptWithPrivateKey, | ||
| UpdateTask: s.UpdateTask, | ||
| } | ||
|
|
There was a problem hiding this comment.
increment thread count in context here
AngithCJ
reviewed
Mar 24, 2023
svc-systems/rpc/systems.go
Outdated
| data := s.EI.DeleteVolume(ctx, req) | ||
| fillSystemProtoResponse(ctx, &resp, data) | ||
| go s.EI.DeleteVolume(ctx, req, &pc, taskID) | ||
| // fillSystemProtoResponse(ctx, &resp, data) |
svc-systems/systems/storage.go
Outdated
|
|
||
| var targetURI = "/redfish/v1/Systems/" + req.SystemID + "/Storage/" + req.StorageInstance + "/Volumes" + req.VolumeID | ||
| //create task | ||
| taskInfo := &common.TaskUpdateInfo{TaskID: taskID, TargetURI: targetURI, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.