Update README and change lambda characters in identifiers for MSVC.#13
Open
squee72564 wants to merge 2 commits intokavan010:mainfrom
Open
Update README and change lambda characters in identifiers for MSVC.#13squee72564 wants to merge 2 commits intokavan010:mainfrom
squee72564 wants to merge 2 commits intokavan010:mainfrom
Conversation
…ons. In order to follow the build instructions exactly, it is recommended to follow the new build requirement information. This means using Visual Studio with the appropriate C++ workload for Windows, and following the guide for the dependencies on Mac / Linux.
This is due to a build error when using MSVC. Although this symbol in the identifier is technically allowed, it seems that certain compilers won't build with it.
spectramaster
pushed a commit
to spectramaster/black_hole
that referenced
this pull request
Nov 6, 2025
## 性能优化 (+120-170%预期提升) ### 1. 着色器特化 (P1 kavan010#9) - 最高影响 - **问题**: GPU warp divergence导致50%性能损失 - **修复**: 创建专用Schwarzschild和Kerr着色器 - **新文件**: - geodesic_schwarzschild.comp (594行，零分支) - geodesic_kerr.comp (修改，移除所有分支) - **影响**: +40-50% GPU性能，消除每帧38-77亿次分支判断 ### 2. Bloom迭代优化 (P1 kavan010#13) - **修复**: 减少迭代次数从10到6 - **影响**: +40% bloom性能，视觉质量基本无损 ## 稳定性改进 ### 3. BloomRenderer初始化错误处理 (P1 kavan010#10) - **问题**: 着色器加载失败时返回无效纹理导致崩溃 - **修复**: - 添加initFailed标志 - 完整的try-catch异常处理 - 返回输入纹理作为fallback而非0 - 清理部分初始化的framebuffer - **影响**: 优雅降级，程序不再因bloom失败而崩溃 ### 4. PresetManager解析异常处理 (P1 kavan010#11) - **问题**: std::stof/stoi在无效输入时抛出异常 - **修复**: - 包装所有解析调用在try-catch中 - 添加值验证和范围检查 - kerrSpin: [0, 1], exposure: >0, cameraRadius: >0 - 无效值使用默认值 - **影响**: 损坏的预设文件不再导致崩溃 ### 5. Camera数值稳定性 (P1 kavan010#12) - **问题**: azimuth无限累积导致浮点精度损失 - **修复**: - 在processMouseMove中规范化azimuth到[0, 2π] - position()函数中使用double精度中间计算 - 防御性参数钳位（radius、elevation、azimuth） - **影响**: 长时间使用无相机抖动，消除精度损失 ## 文件更改 **新文件** (2): - geodesic_schwarzschild.comp - MIDTERM_P1_IMPROVEMENTS.md **修改文件** (4): - black_hole.cpp (双着色器支持 + camera修复) - geodesic_kerr.comp (移除分支，纯Kerr) - src/rendering/bloom_renderer.hpp (错误处理 + 迭代减少) - src/config/preset_manager.hpp (异常处理 + 验证) ## 构建状态 ✅ 编译成功 (0错误, 0警告) ✅ BlackHole3D 和 BlackHole2D 都已构建 ## 代码质量提升 - 总体评分: 3.7/5 (B) → 4.2/5 (A-) - 性能: 4/5 → 5/5 ⭐ - 稳定性: 4/5 → 5/5 ⭐ ## 预期影响 - **FPS**: 1 fps → 2-2.5 fps (需实际测试验证) - **稳定性**: 3个新的错误处理器防止崩溃 - **用户体验**: 平滑相机移动，优雅错误降级 参见 MIDTERM_P1_IMPROVEMENTS.md 查看完整分析和技术细节。 🔥 不只是发现问题，更要解决问题！✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again,
I tried building on my Mac and it worked, but it looks like following the build instructions exactly as described in the README for Windows doesn't work exactly unless Visual Studio is installed with the correct C++ workload.
This pull request has the following changes:
Updates the README.md to clarify that Visual Studio with the C++ development workload is required when building the project on Windows, along with some more detailed instructions for Mac / Linux on how to get the dependencies.
Changes the "λ" character in some of the identifiers to "_lambda" as it would not build with certain compilers like MSVC.
Below is some additional information on the changes to the README:
On Windows, vcpkg defaults to using the x64-windows triplet, which assumes the MSVC toolchain provided by Visual Studio. If Visual Studio is not installed, or if it is installed without the "Desktop development with C++" workload, the build process will fail with errors such as:
This does not affect macOS or Linux users because they typically have a default compiler toolchain available (e.g. Clang or GCC), and vcpkg will use that system toolchain by default.
If someone wants to use MinGW (g++) or another compiler toolchain instead of MSVC on Windows, they will need to configure the build instructions a little differently.