Conversation
Added support for objectMode streaming.
Added support for object mode streaming.
|
I have reviewed some of the code here. I haven’t had too much experience in our jsonexport in regards to streaming. However, what I think I am reading here sounds amazing. @air2 could you please elaborate how this works, if I understand correctly we can now stream, with your code, in chunks of valid json-to-object... If you could elaborate please. I am a contributor and could help along if I also better understood a better picture here please and thank you |
|
Also it would help me if you were able to provide a unit test in any fashion to accompany this PR |
kaue
left a comment
There was a problem hiding this comment.
Would be great if we can include some tests & docs for the new objectMode option
| if (this._options.objectMode) { | ||
| json = Array.isArray(chunk) ? chunk : [chunk]; | ||
| } | ||
| else { |
There was a problem hiding this comment.
I would remove this else to keep this part less indented
Status
READY
Description
This commit supports streaming objects, instead of stringified JSON, by adding objectMode to the options and implementing it in the stream.js
Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
Impacted Areas in Application
List general components of the application that this PR will affect: