replace production panics with graceful error handling in common crate#844
Open
adilhafeez wants to merge 1 commit intomainfrom
Open
replace production panics with graceful error handling in common crate#844adilhafeez wants to merge 1 commit intomainfrom
adilhafeez wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open_ai.rs: Replacepanic!("Unsupported content type")inDisplayimpl with silently skipping unknown content types (same asImageUrlhandling) — prevents crash when logging messages with new content typesratelimit.rs: Replacepanic!("repeated selector")withlog::error!and skip the duplicate — prevents crash on config typo with duplicate rate limit selectorshttp.rs: Replacepanic!("Duplicate http call")withlog::warn!— prevents crash if proxy-wasm runtime generates a duplicate call token IDAlso removes unused
core::{panic, str}import that became dead code after the fix.Test plan
cargo test --lib -p common— all 36 tests passcargo clippy --locked --all-targets --all-features -- -D warnings— cleancargo fmt --all -- --check— clean