add token_counting_strategy override for provider-aware token counting#843
Open
adilhafeez wants to merge 2 commits intomainfrom
Open
add token_counting_strategy override for provider-aware token counting#843adilhafeez wants to merge 2 commits intomainfrom
adilhafeez wants to merge 2 commits intomainfrom
Conversation
By default, use cheap len/4 estimate for input token counting (metrics and ratelimit). When enable_token_counting is set to true in overrides, use tiktoken BPE for exact counts. This eliminates ~80ms of per-request latency from tiktoken in the WASM filter while keeping metrics and ratelimit functional. Made-with: Cursor
adilhafeez
force-pushed
the
adil/optional-token-counting
branch
from
a295a1b to
e5f3039
Compare
adilhafeez
changed the title
adilhafeez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add token_counting_strategy override (estimate|auto) for provider-aware token counting
use len/4 token estimate by default, make tiktoken opt-in via enable_token_counting. This takes out around ~80ms time from request,