Skip to content

Compact and deduplicate test suite #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilhafeez wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Compact and deduplicate test suite #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4634d0
compact and deduplicate test suite
adilhafeez Mar 15, 2026
74f9b44
fix black formatting for Python test files
adilhafeez Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
283 changes: 116 additions & 167 deletions cli/test/test_config_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,11 @@ def cleanup_env(monkeypatch):
monkeypatch.undo()


def test_validate_and_render_happy_path(monkeypatch):
monkeypatch.setenv("PLANO_CONFIG_FILE", "fake_plano_config.yaml")
monkeypatch.setenv("PLANO_CONFIG_SCHEMA_FILE", "fake_plano_config_schema.yaml")
monkeypatch.setenv("ENVOY_CONFIG_TEMPLATE_FILE", "./envoy.template.yaml")
monkeypatch.setenv("PLANO_CONFIG_FILE_RENDERED", "fake_plano_config_rendered.yaml")
monkeypatch.setenv("ENVOY_CONFIG_FILE_RENDERED", "fake_envoy.yaml")
monkeypatch.setenv("TEMPLATE_ROOT", "../")

plano_config = """
@pytest.mark.parametrize(
"plano_config",
[
# Case 1: LLM provider config
"""
version: v0.1.0

listeners:
Expand Down Expand Up @@ -49,40 +45,9 @@ def test_validate_and_render_happy_path(monkeypatch):

tracing:
random_sampling: 100
"""
plano_config_schema = ""
with open("../config/plano_config_schema.yaml", "r") as file:
plano_config_schema = file.read()

m_open = mock.mock_open()
# Provide enough file handles for all open() calls in validate_and_render_schema
m_open.side_effect = [
# Removed empty read - was causing validation failures
mock.mock_open(read_data=plano_config).return_value, # PLANO_CONFIG_FILE
mock.mock_open(
read_data=plano_config_schema
).return_value, # PLANO_CONFIG_SCHEMA_FILE
mock.mock_open(read_data=plano_config).return_value, # PLANO_CONFIG_FILE
mock.mock_open(
read_data=plano_config_schema
).return_value, # PLANO_CONFIG_SCHEMA_FILE
mock.mock_open().return_value, # ENVOY_CONFIG_FILE_RENDERED (write)
mock.mock_open().return_value, # PLANO_CONFIG_FILE_RENDERED (write)
]
with mock.patch("builtins.open", m_open):
with mock.patch("planoai.config_generator.Environment"):
validate_and_render_schema()


def test_validate_and_render_happy_path_agent_config(monkeypatch):
monkeypatch.setenv("PLANO_CONFIG_FILE", "fake_plano_config.yaml")
monkeypatch.setenv("PLANO_CONFIG_SCHEMA_FILE", "fake_plano_config_schema.yaml")
monkeypatch.setenv("ENVOY_CONFIG_TEMPLATE_FILE", "./envoy.template.yaml")
monkeypatch.setenv("PLANO_CONFIG_FILE_RENDERED", "fake_plano_config_rendered.yaml")
monkeypatch.setenv("ENVOY_CONFIG_FILE_RENDERED", "fake_envoy.yaml")
monkeypatch.setenv("TEMPLATE_ROOT", "../")

plano_config = """
""",
# Case 2: Agent config
"""
version: v0.3.0

agents:
Expand Down Expand Up @@ -122,25 +87,30 @@ def test_validate_and_render_happy_path_agent_config(monkeypatch):
model_providers:
- access_key: ${OPENAI_API_KEY}
model: openai/gpt-4o
"""
""",
],
ids=["llm_provider_config", "agent_config"],
)
def test_validate_and_render_happy_path(monkeypatch, plano_config):
monkeypatch.setenv("PLANO_CONFIG_FILE", "fake_plano_config.yaml")
monkeypatch.setenv("PLANO_CONFIG_SCHEMA_FILE", "fake_plano_config_schema.yaml")
monkeypatch.setenv("ENVOY_CONFIG_TEMPLATE_FILE", "./envoy.template.yaml")
monkeypatch.setenv("PLANO_CONFIG_FILE_RENDERED", "fake_plano_config_rendered.yaml")
monkeypatch.setenv("ENVOY_CONFIG_FILE_RENDERED", "fake_envoy.yaml")
monkeypatch.setenv("TEMPLATE_ROOT", "../")

plano_config_schema = ""
with open("../config/plano_config_schema.yaml", "r") as file:
plano_config_schema = file.read()

m_open = mock.mock_open()
# Provide enough file handles for all open() calls in validate_and_render_schema
m_open.side_effect = [
# Removed empty read - was causing validation failures
mock.mock_open(read_data=plano_config).return_value, # PLANO_CONFIG_FILE
mock.mock_open(
read_data=plano_config_schema
).return_value, # PLANO_CONFIG_SCHEMA_FILE
mock.mock_open(read_data=plano_config).return_value, # PLANO_CONFIG_FILE
mock.mock_open(
read_data=plano_config_schema
).return_value, # PLANO_CONFIG_SCHEMA_FILE
mock.mock_open().return_value, # ENVOY_CONFIG_FILE_RENDERED (write)
mock.mock_open().return_value, # PLANO_CONFIG_FILE_RENDERED (write)
mock.mock_open(read_data=plano_config).return_value,
mock.mock_open(read_data=plano_config_schema).return_value,
mock.mock_open(read_data=plano_config).return_value,
mock.mock_open(read_data=plano_config_schema).return_value,
mock.mock_open().return_value,
mock.mock_open().return_value,
]
with mock.patch("builtins.open", m_open):
with mock.patch("planoai.config_generator.Environment"):
Expand Down Expand Up @@ -344,124 +314,103 @@ def test_validate_and_render_schema_tests(monkeypatch, plano_config_test_case):
validate_and_render_schema()


def test_convert_legacy_llm_providers():
from planoai.utils import convert_legacy_listeners

listeners = {
"ingress_traffic": {
"address": "0.0.0.0",
"port": 10000,
"timeout": "30s",
},
"egress_traffic": {
"address": "0.0.0.0",
"port": 12000,
"timeout": "30s",
},
}
llm_providers = [
{
"model": "openai/gpt-4o",
"access_key": "test_key",
}
]

updated_providers, llm_gateway, prompt_gateway = convert_legacy_listeners(
listeners, llm_providers
)
assert isinstance(updated_providers, list)
assert llm_gateway is not None
assert prompt_gateway is not None
print(json.dumps(updated_providers))
assert updated_providers == [
{
"name": "egress_traffic",
"type": "model_listener",
"port": 12000,
"address": "0.0.0.0",
"timeout": "30s",
"model_providers": [{"model": "openai/gpt-4o", "access_key": "test_key"}],
},
{
"name": "ingress_traffic",
"type": "prompt_listener",
"port": 10000,
"address": "0.0.0.0",
"timeout": "30s",
},
]

assert llm_gateway == {
"address": "0.0.0.0",
"model_providers": [
@pytest.mark.parametrize(
"listeners,expected_providers,expected_llm_gateway,expected_prompt_gateway",
[
# Case 1: With prompt gateway (ingress + egress)
(
{
"ingress_traffic": {
"address": "0.0.0.0",
"port": 10000,
"timeout": "30s",
},
"egress_traffic": {
"address": "0.0.0.0",
"port": 12000,
"timeout": "30s",
},
},
[
{
"name": "egress_traffic",
"type": "model_listener",
"port": 12000,
"address": "0.0.0.0",
"timeout": "30s",
"model_providers": [
{"model": "openai/gpt-4o", "access_key": "test_key"}
],
},
{
"name": "ingress_traffic",
"type": "prompt_listener",
"port": 10000,
"address": "0.0.0.0",
"timeout": "30s",
},
],
{
"address": "0.0.0.0",
"model_providers": [
{"access_key": "test_key", "model": "openai/gpt-4o"}
],
"name": "egress_traffic",
"type": "model_listener",
"port": 12000,
"timeout": "30s",
},
{
"address": "0.0.0.0",
"name": "ingress_traffic",
"port": 10000,
"timeout": "30s",
"type": "prompt_listener",
},
),
# Case 2: Without prompt gateway (egress only)
(
{"egress_traffic": {"address": "0.0.0.0", "port": 12000, "timeout": "30s"}},
[
{
"address": "0.0.0.0",
"model_providers": [
{"access_key": "test_key", "model": "openai/gpt-4o"}
],
"name": "egress_traffic",
"port": 12000,
"timeout": "30s",
"type": "model_listener",
}
],
{
"access_key": "test_key",
"model": "openai/gpt-4o",
"address": "0.0.0.0",
"model_providers": [
{"access_key": "test_key", "model": "openai/gpt-4o"}
],
"name": "egress_traffic",
"type": "model_listener",
"port": 12000,
"timeout": "30s",
},
],
"name": "egress_traffic",
"type": "model_listener",
"port": 12000,
"timeout": "30s",
}

assert prompt_gateway == {
"address": "0.0.0.0",
"name": "ingress_traffic",
"port": 10000,
"timeout": "30s",
"type": "prompt_listener",
}


def test_convert_legacy_llm_providers_no_prompt_gateway():
None,
),
],
ids=["with_prompt_gateway", "without_prompt_gateway"],
)
def test_convert_legacy_llm_providers(
listeners, expected_providers, expected_llm_gateway, expected_prompt_gateway
):
from planoai.utils import convert_legacy_listeners

listeners = {
"egress_traffic": {
"address": "0.0.0.0",
"port": 12000,
"timeout": "30s",
}
}
llm_providers = [
{
"model": "openai/gpt-4o",
"access_key": "test_key",
}
]

llm_providers = [{"model": "openai/gpt-4o", "access_key": "test_key"}]
updated_providers, llm_gateway, prompt_gateway = convert_legacy_listeners(
listeners, llm_providers
)
assert isinstance(updated_providers, list)
assert llm_gateway is not None
assert prompt_gateway is not None
assert updated_providers == [
{
"address": "0.0.0.0",
"model_providers": [
{
"access_key": "test_key",
"model": "openai/gpt-4o",
},
],
"name": "egress_traffic",
"port": 12000,
"timeout": "30s",
"type": "model_listener",
}
]
assert llm_gateway == {
"address": "0.0.0.0",
"model_providers": [
{
"access_key": "test_key",
"model": "openai/gpt-4o",
},
],
"name": "egress_traffic",
"type": "model_listener",
"port": 12000,
"timeout": "30s",
}
assert updated_providers == expected_providers
assert llm_gateway == expected_llm_gateway
if expected_prompt_gateway is not None:
assert prompt_gateway == expected_prompt_gateway
29 changes: 11 additions & 18 deletions cli/test/test_version_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,17 @@ def test_current_is_newer(self):
assert status["is_outdated"] is False
assert status["message"] is None

def test_major_version_outdated(self):
status = check_version_status("0.4.1", "1.0.0")
assert status["is_outdated"] is True

def test_minor_version_outdated(self):
status = check_version_status("0.4.1", "0.5.0")
assert status["is_outdated"] is True

def test_patch_version_outdated(self):
status = check_version_status("0.4.1", "0.4.2")
@pytest.mark.parametrize(
"current,latest",
[
("0.4.1", "1.0.0"), # major
("0.4.1", "0.5.0"), # minor
("0.4.1", "0.4.2"), # patch
],
ids=["major", "minor", "patch"],
)
def test_version_outdated(self, current, latest):
status = check_version_status(current, latest)
assert status["is_outdated"] is True

def test_latest_is_none(self):
Expand Down Expand Up @@ -153,11 +154,3 @@ def test_up_to_date_version(self):
status = check_version_status(current_version, latest)

assert status["is_outdated"] is False

def test_skip_version_check_env_var(self, monkeypatch):
"""Test that PLANO_SKIP_VERSION_CHECK skips the check."""
monkeypatch.setenv("PLANO_SKIP_VERSION_CHECK", "1")

import os

assert os.environ.get("PLANO_SKIP_VERSION_CHECK") == "1"
6 changes: 0 additions & 6 deletions crates/brightstaff/src/handlers/function_calling.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,12 +1481,6 @@ mod tests {
assert!(config.format_prompt.contains(r#"{\"tool_calls\": [{"#));
}

#[test]
fn test_arch_agent_config_default() {
let config = ArchAgentConfig::default();
assert_eq!(config.generation_params.temperature, 0.01); // Different from ArchFunctionConfig
}

#[test]
fn test_fix_json_string_valid() {
let handler = ArchFunctionHandler::new(
Expand Down
Loading
Loading