This repository was archived by the owner on May 12, 2021. It is now read-only.
log: Add syslog support #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2018 15:54
This commit updates the proxy vendoring so that we can rely on latest versions of the vendored packages. Fixes kata-containers#24 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Logrus is imported directly from the proxy code, but no explicit constraint was set up. Fixes kata-containers#24 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
This commit allows the proxy to log to syslog so that debugging will get easier. Indeed, all logs will end up in the journal. Fixes kata-containers#22 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 37.36% 34.34% -3.02%
==========================================
Files 1 1
Lines 91 99 +8
==========================================
Hits 34 34
- Misses 50 58 +8
Partials 7 7
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
|
LGTM |
jodh-intel
reviewed
Jan 15, 2018
| logrus.SetLevel(level) | ||
| proxyLog.SetLevel(level) | ||
|
|
||
| hook, err := lSyslog.NewSyslogHook("", "", syslog.LOG_INFO, "") |
There was a problem hiding this comment.
The last arg here needs to be proxyName - see clearcontainers/proxy#181.
|
Dang - too late ;) |
|
/me raises PR... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first re-vendors the proxy, then it constraints the logrus version to be v1.0.4 instead of v1.0.3.
At last, the most important part of this PR is that we enable the proxy logging towards the syslog to centralize all proxy logs to the system journal.
Fixes #22 #24