feat(app): replace topic-based grouping with plan-based instance grouping#6
Open
feat(app): replace topic-based grouping with plan-based instance grouping#6
Conversation
- Add stateMoveTo case to View() so the plan-assign picker is actually
rendered (was falling through to default, invisible to the user)
- Fix cancel_plan goroutine race: remove model mutations from the async
action; return planRefreshMsg{} so Update applies them on the main loop
- Fix kill_running_instances_in_plan race: snapshot instances before the
goroutine, call inst.Kill() (I/O only) in the goroutine, return
killPlanInstancesMsg; add Update handler + List.RemoveByPlan for the
model mutations; drop the dead OnConfirm path entirely
- Propagate sidebar selected plan file (PlanFile) into new instances
created via KeyPrompt ('N'), KeyNew ('n'), and KeyNewSkipPermissions
('S') so new instances are grouped under the active plan
- Update test to use pendingConfirmAction flow instead of the defunct
OnConfirm callback; add targeted tests for each fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanFileinstead of topic name; sidebar selection filters the instance list to show only instances assigned to that plan (or "ungrouped" instances)GroupStatustype; search match highlighting is keyed by plan filemkeybind → Assign to Plan: Pressingmon an instance opens a picker overlay to reassign it to any known planfilterInstancesByTopic,filterSearchWithTopic,KillInstancesByTopic, andSetSearchFilterWithTopic— all callers updated to the plan-based equivalentsTest Plan
go test ./... -count=1— all packages green