Skip to content

Conversation

@rstoldt
Copy link

@rstoldt rstoldt commented Mar 21, 2013

Changed he request variable to IDictionary<string, object>. Modified the code to pass same - works great now.

@kasperbumbech
Copy link
Owner

Hi Rich,

The filechanges seems a little strange, I can see that this is the changes to the existing file ItemService, but cant make out the exact change from the pull-request.

I would like to merge the change, but can I get you to do another pull request with only the exact file-changes ?

Best regards,

Kasper

@rstoldt
Copy link
Author

rstoldt commented Mar 21, 2013

Hi Kasper –

Appreciate your contribution – you can’t imagine how much!

I’ll try to figure out how to do that. It took me 5 days to get to this point – I’m a bit gun-shy since I’m such a complete n00b ☺

Thanks,
Rich

O – 201.447.5223
M – 201.403.1244

From: kasperbumbech [mailto:notifications@github.com]
Sent: Thursday, March 21, 2013 5:11 PM
To: kasperbumbech/Podio.API-for-.NET
Cc: Richard Stoldt (3P)
Subject: Re: [Podio.API-for-.NET] Fix for FilterItems methods in ItemService class (#10)

Hi Rich,

The filechanges seems a little strange, I can see that this is the changes to the existing file ItemService, but cant make out the exact change from the pull-request.

I would like to merge the change, but can I get you to do another pull request with only the exact file-changes ?

Best regards,

Kasper


Reply to this email directly or view it on GitHubhttps://github.com//pull/10#issuecomment-15265624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants