fix: separate db-init-job annotations to prevent ArgoCD deadlock #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created dedicated components.init_db.annotations configuration separate from components.api.annotations. The db-init-job template now uses this dedicated variable instead of sharing the API annotations. Default value includes helm.sh/hook: pre-install for Helm deployments, but ArgoCD users can override this to remove the hook and prevent deployment deadlocks. Changes: - Added components.init_db.annotations and components.init_db.labels to values.yaml - Updated db-init-job template to use init_db instead of api variables - Documented ArgoCD override requirement in values comments This prevents the deadlock where: 1. ArgoCD adds hook-finalizer when it sees helm.sh/hook annotation 2. ArgoCD waits for db-init-job hook before deploying wave 3 3. db-init-job waits for PostgreSQL (wave 3) 4. Result: infinite wait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created dedicated
components.init_db.annotationsconfiguration separate fromcomponents.api.annotations.The db-init-job template now uses this dedicated variable instead of sharing the API annotations.
Default value includes
helm.sh/hook: pre-installfor Helm deployments, but ArgoCD users can override this to remove the hook and prevent deployment deadlocks.Changes:
components.init_db.annotationsandcomponents.init_db.labelstovalues.yamldb-init-jobtemplate to useinit_dbinstead ofapivariablesThis prevents the deadlock where:
db-init-jobhook before deploying wave 3db-init-jobwaits for PostgreSQL (wave 3)