Fixes for replacing the obsolete Examine() #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build on docker
Revert "Build on docker"
Update from upstream
walkero-gr
commented
Feb 7, 2023
| ) | ||
| add_library(jsc STATIC ${JSC_SRC}) | ||
| add_dependencies(jsc wtf wtfurl) | ||
| add_dependencies(jsc wtf) |
Author
There was a problem hiding this comment.
This is necessary because wtfurl doesn't exist and newer versions of cmake shows it as an error breaking the compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in asl.cpp is necessary to replace the Examine() that is obsolete, replacing it with ExamineObjectTags()