feat: add CUDA availability check with helpful error message#176
Open
tykoo-chen wants to merge 1 commit intokarpathy:masterfrom
Open
feat: add CUDA availability check with helpful error message#176tykoo-chen wants to merge 1 commit intokarpathy:masterfrom
tykoo-chen wants to merge 1 commit intokarpathy:masterfrom
Conversation
Currently train.py assumes CUDA is available and will crash with a cryptic error if no GPU is detected. This adds an early check with a helpful message pointing users to: - MLX forks for Mac users - CUDA driver installation for Windows/Linux users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently
train.pyassumes CUDA is available and will crash with a cryptic error if no GPU is detected:torch.cuda.get_device_capability()throws an exceptionSolution
Add an early check for CUDA availability before any CUDA operations, with a helpful error message that:
Code Change
Benefits