This repository was archived by the owner on Jul 28, 2023. It is now read-only.
fix(launcher) workers fail to launch after tunnel#43
Open
aminer-looker wants to merge 1 commit intokarma-runner:masterfrom
Open
fix(launcher) workers fail to launch after tunnel#43aminer-looker wants to merge 1 commit intokarma-runner:masterfrom
aminer-looker wants to merge 1 commit intokarma-runner:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
824d524 to
4cf2caa
Compare
In some environments, the process which establishes the tunnel can report that it is operational significantly before the tunnel is actually established. This will cause subsequent calls to create a worker to fail. This change waits a short interval after the tunnel process has reported itself started to allow it to actually finish establishing the tunnel before attempting to create any workers. Fixes karma-runner#42
4cf2caa to
54f4952
Compare
Author
|
My company, Looker Data Services, Inc., has signed the CLA. |
Member
|
I'm not a big fan of introducing a fixed delay for everyone. Would it be possible to test immediately if the connection is working, and if not do a check every second for 5 seconds or something like that until it becomes available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments, the process which establishes the tunnel can
report that it is operational significantly before the tunnel is
actually established. This will cause subsequent calls to create a
worker to fail.
This change waits a short interval after the tunnel process has
reported itself started to allow it to actually finish establishing
the tunnel before attempting to create any workers.
Fixes #42