Skip to content

changed $should_cache default #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlkowald wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

changed $should_cache default #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ac56e7
changed $should_cache default
karlkowald May 17, 2022
341248d
raise requirements to PHP 5.6 and WP 4.7 (#259) (#268)
stklcode May 17, 2022
3d1f362
Merge branch 'develop' into karlkowald-bugfix-cache-wrong-statuscodes
stklcode May 17, 2022
4d0315d
yoda and line breaks
stklcode May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file. This projec

## unreleased

Requires PHP 5.6 and WordPress 4.7 or above

* Enhance: adjust styling for setup instructions (#215, props timse201)


Expand Down
9 changes: 8 additions & 1 deletion inc/class-cachify.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,7 +1392,14 @@ public static function set_cache( $data ) {
* @param string $cache_hash The cache hash.
* @param int $cache_expires Cache validity period.
*/
$should_cache = apply_filters( 'cachify_store_item', true, $data, self::$method, self::_cache_hash(), self::_cache_expires() );
$should_cache = apply_filters(
'cachify_store_item',
200 === http_response_code(),
$data,
self::$method,
self::_cache_hash(),
self::_cache_expires()
);

/* Save? */
if ( $should_cache ) {
Expand Down
4 changes: 2 additions & 2 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<exclude-pattern>vendor/*</exclude-pattern>

<!-- WordPress coding standards -->
<config name="minimum_supported_wp_version" value="4.4"/>
<config name="minimum_supported_wp_version" value="4.7"/>
<rule ref="WordPress"/>
<rule ref="WordPress.WP.I18n">
<properties>
Expand All @@ -29,6 +29,6 @@
</rule>

<!-- Include sniffs for PHP cross-version compatibility. -->
<config name="testVersion" value="5.2-"/>
<config name="testVersion" value="5.6-"/>
<rule ref="PHPCompatibilityWP"/>
</ruleset>
6 changes: 3 additions & 3 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
* Contributors: pluginkollektiv
* Donate link: https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=TD4AMD2D8EMZW
* Tags: acceleration, cache, caching, minimize, performance, apc, disk, hdd, memcached, compression, minify, speed
* Requires at least: 4.4
* Tested up to: 5.8
* Requires PHP: 5.2.4
* Requires at least: 4.7
* Tested up to: 5.9
* Requires PHP: 5.6
* Stable tag: 2.3.2
* License: GPLv2 or later
* License URI: http://www.gnu.org/licenses/gpl-2.0.html
Expand Down