Improve mobile UX for calculators, restrict Best Mix depth, and extensive linting fixes #140
+1,324
−985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sive linting fixes - In the Gas Fill Price calculator, show the formula (Tank Size x Bars x Gas %) below the "Total O2 Needed" and "Total Helium Needed" labels. - Compact the layout of all calculators (MOD, Best Mix, Gas Fill Price, Gas Planning, Min Gas, SAC Rate, Weight) on mobile devices by reducing padding, margins, and font sizes. - Optimize result boxes with responsive text sizing to prevent overflow on small screens. - In Best Mix Calculator, restrict the maximum depth slider based on pO2 limit when Trimix is disabled to prevent hypoxic mixes. - Added `showSwitchMode` prop to `GasTanksInput` and hid mode switching buttons when used within planning tools (Weight and Tank Buoyancy). - Refactored `AdvancedDiveProfileChart.js` to reduce complexity, added PropTypes, and resolved numerous linting and accessibility warnings. - Fixed over 400 lint warnings across multiple components including `SocialMediaIcons.js`, `StickyFilterBar.js`, `WindOverlay.js`, `WeightCalculator.js`, `GasTanksInput.js`, `GasMixInput.js`, `FormField.js`, `Combobox.js`, and several Admin tables. - Improved accessibility by associating labels with controls, adding keyboard interactions to sortable table headers, and ensuring interactive elements are accessible. - Optimized `StickyFilterBar.js` using `useMemo` and removed unused imports and console statements throughout the codebase.
kargig
force-pushed
the
frontend_updates
branch
from
c164d6a to
eace377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showSwitchModeprop toGasTanksInputand hid mode switching buttons when used within planning tools (Weight and Tank Buoyancy).AdvancedDiveProfileChart.jsto reduce complexity, added PropTypes, and resolved numerous linting and accessibility warnings.SocialMediaIcons.js,StickyFilterBar.js,WindOverlay.js,WeightCalculator.js,GasTanksInput.js,GasMixInput.js,FormField.js,Combobox.js, and several Admin tables.StickyFilterBar.jsusinguseMemoand removed unused imports and console statements throughout the codebase.